Repository navigation
Bump FAKE build tooling to 6.1.4 - #19
Merged
Merged
Conversation
Fake.Api.GitHub 5.20.4 pinned Octokit to 0.48 because 0.50+ broke API compatibility. FAKE 6.1.4 depends on Octokit >= 13.0.1 directly, so the pin is no longer needed. Also required unpinning FSharp.Core in the build group (FAKE 6.x needs FSharp.Core >= 8.0.400).
Bumping FAKE pulled Microsoft.Build.* up to 18.10.1, which only ships net11.0 and net472 libs. On net10.0 nothing gets copied to the build output, so FAKE's binlog parsing failed to load Microsoft.Build.Framework and reported every successful build as a failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fake.*packages in the build group from 5.20.4 to 6.1.4Octokit 0.48pin (no longer needed: FAKE 6.1.4 depends on Octokit >= 13.0.1 directly), resolves to Octokit 14.0.0FSharp.Core ~> 5in the build group since FAKE 6.x requires FSharp.Core >= 8.0.400Microsoft.Build.Framework/Microsoft.Build.Utilities.Core/Microsoft.NET.StringToolsto~> 17.14The MSBuild pin is needed because the FAKE bump pulled those up to 18.10.1, which only ships
net11.0and
net472libs. Onnet10.0nothing gets copied to the build output, so FAKE's binlog parsing threwCould not load Microsoft.Build.Framework, Version=15.1.0.0and reported every successful build as afailure. 17.14 ships
net9.0, which works, and also silences the "doesn't support net10.0" warnings.Test plan
BlackFox.MasterOfFoo.Buildproject compiles against FAKE 6.1.4, with no warnings