Repository navigation
perf(core): update log event JSON size cache incrementally on insert and remove - #27099
Draft
gwenaskell wants to merge 2 commits into
Draft
gwenaskell wants to merge 2 commits into
gwenaskell wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LogEvent::insertandLogEvent::removeused to invalidate the cached estimated JSON size, so every component that touched a single field paid a full walk of the event at its output.The cache is now updated from the inserted, replaced and removed values when the target's parent object already exists:
+ new - old+ "key":value, plus a comma if the object was not empty- "key":value, minus a comma if the object had other membersInner::clonenow keeps the JSON size cache so the update also works afterArc::make_mut.Fallbacks to invalidation (same behavior as before):
remove_prune(.., true)get_mut/value_mutaccesssize_cache(ByteSizeOf) is still invalidated.Not covered:
remap, sinceVrlTargetgoes throughinto_parts/from_partsand drops the cache.References
Vector configuration
N/A
How did you test this PR?
Does this PR include user facing changes?
no-changeloglabel to this PR.