fix(compiler): lower dynamic any-local operators - #319
Merged
Conversation
Fixes #290 Co-authored-by: Mateus Mamede Lage <23098414+mmamedel@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--dynamicpromise for binary operators onanylocals whose values remain in checked-dynamic storageFixes #290.
Validation
--dynamiccoverage reports 33% dynamically compiled with no blockers; execution prints42pnpm -r --filter "./packages/*" run buildany/checked-dynamic corpus family (8 passed)pnpm test:ts7(140 passed; all 1,345 entries)pnpm test:sandbox: all 16 environments built and every completed plain/sanitized suite was green; the managed Vercel fallback lost the sanitized 8/8 stream before command completion and its status probe returned 125 (no exit record), so the hosted gate could not report completepnpm lintremains red on four pre-existingmainviolations: unused imports inpackages/cli/src/main.tsandpackages/compiler/src/backend/external-c.ts, an unsafe optional-chain assertion inpackages/compiler/src/backend/native-codegen.test.ts, and the pre-existingprefer-constatpackages/compiler/src/frontend/lowering/lower-exprs.ts:4091. The new lowering hunks add no lint violation.