Skip to content

Remove unused return values from getPageStaticInfo - #97661

Merged
mischnic merged 1 commit into
canaryfrom
mischnic/cleanup-getPagesPageStaticInfo
Aug 24, 2026
Merged

Remove unused return values from getPageStaticInfo#97661
mischnic merged 1 commit into
canaryfrom
mischnic/cleanup-getPagesPageStaticInfo

Conversation

@mischnic

@mischnic mischnic commented Aug 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Some cleanup, this was never used:

  • config from getStaticInfoIncludingLayouts
  • getServerSideProps and getStaticProps from pages router

@mischnic Graphite App

mischnic commented Aug 21, 2026

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mischnic mischnic mentioned this pull request Aug 21, 2026
Draft
2 of 3 tasks
@github-actions

github-actions Bot commented Aug 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Tests Passed

Commit: 86fba56

@github-actions

github-actions Bot commented Aug 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Stats from current PR

🔴 4 regressions

Metric Canary PR Change Trend
Turbo Build Time 6.034s 6.396s 🔴 +362ms (+6%) ▄▃█▄▁
Turbo Build Time (cached) 3.035s 3.201s 🔴 +166ms (+5%) ▃▂▅▃▁
Webpack Build Time (cached) 25.233s 26.492s 🔴 +1.259s (+5%) ▁▁▁▁▂
Webpack Warm (First Request) 3.462s 3.579s 🔴 +117ms (+3%) ▁▁▁▁▂
📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 813ms 813ms ✓ ████▁
Cold (Ready in log) 786ms 810ms ✓ ▇▅█▆▂
Cold (First Request) 1.254s 1.329s ✓ ▆▄█▅▂
Warm (Listen) 813ms 814ms ✓ ████▁
Warm (Ready in log) 794ms 818ms ✓ ▆▄█▅▁
Warm (First Request) 1.258s 1.315s ✓ ▅▃█▄▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 815ms 864ms ✓ ▁▁▁▁▁
Cold (Ready in log) 814ms 830ms ✓ ▁▁▁▁▁
Cold (First Request) 3.442s 3.504s ✓ ▁▂▁▁▂
Warm (Listen) 814ms 864ms ✓ ▁▁▁▁▁
Warm (Ready in log) 812ms 832ms ✓ ▁▁▁▁▁
Warm (First Request) 3.462s 3.579s 🔴 +117ms (+3%) ▁▁▁▁▂

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 6.034s 6.396s 🔴 +362ms (+6%) ▄▃█▄▁
Cached Build 3.035s 3.201s 🔴 +166ms (+5%) ▃▂▅▃▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 25.471s 25.771s ✓ ▁▁▁▁▂
Cached Build 25.233s 26.492s 🔴 +1.259s (+5%) ▁▁▁▁▂
node_modules Size 554 MB 554 MB ✓ █████
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles
Canary PR Change
050icza-xjz0i.js gzip 5.73 kB N/A -
05ph4oirz116a.js gzip 156 B N/A -
07jdby0ue616s.js gzip 450 B N/A -
0bjdc8muo74n5.js gzip 8.71 kB N/A -
0cz1d0mv5g_q7.js gzip 39.4 kB 39.4 kB ✓
0g2xf3eygzg2u.js gzip 155 B N/A -
0rci1f3or1a19.js gzip 13.3 kB N/A -
0s91umvum_m47.js gzip 159 B N/A -
1_2x714--ii1i.js gzip 8.76 kB N/A -
1-3y752pkth5-.js gzip 10 kB N/A -
19gb-1_5udxfb.js gzip 13.2 kB N/A -
19gug1p0oi4bu.js gzip 156 B N/A -
1elt1qium-r2m.css gzip 115 B 115 B ✓
1pjlaheggdid3.js gzip 156 B N/A -
1tf1phijqlx9j.js gzip 220 B 220 B ✓
1uzabyd1120a1.js gzip 8.71 kB N/A -
2_44e_iy02kyz.js gzip 154 B N/A -
2-ufv8lc-g7gg.js gzip 10.6 kB N/A -
2130w30-tm_h8.js gzip 157 B N/A -
21kmjy_10x14f.js gzip 8.81 kB N/A -
22q638590y5jx.js gzip 150 B N/A -
28dhc6t85q1_p.js gzip 8.78 kB N/A -
2f-ilvczue-tp.js gzip 9.46 kB N/A -
2f1u17u5c8iny.js gzip 8.79 kB N/A -
2i33es40sspid.js gzip 65.6 kB N/A -
2ikltg_8iegxw.js gzip 10.3 kB N/A -
2ixp3xn2_vz0r.js gzip 3.57 kB N/A -
2odd5ge32l1g8.js gzip 154 B N/A -
2r7h28568golh.js gzip 71.6 kB N/A -
2vst0p6zpfrr_.js gzip 7.53 kB N/A -
2vxi673cz1-t4.js gzip 8.79 kB N/A -
2wjd6xcc9ads4.js gzip 168 B N/A -
36-p0_enxkb2k.js gzip 47 kB N/A -
38-q43pzktqhs.js gzip 1.46 kB N/A -
3cyegytivg78e.js gzip 154 B N/A -
3nbojhxiy1qv_.js gzip 13.7 kB N/A -
3ti2v9sjhbrxj.js gzip 154 B N/A -
41u5s3oe2-erp.js gzip 2.29 kB N/A -
43s3no1vc_z7i.js gzip 154 B N/A -
445s_9hf8o7ao.js gzip 8.76 kB N/A -
turbopack-0d..9ejy.js gzip 3.74 kB 3.74 kB ✓
0-6bcj16ji2wf.js gzip N/A 10.6 kB -
07ryk0jced-sc.js gzip N/A 8.78 kB -
0e15gb28orz2_.js gzip N/A 152 B -
0jwho9fkrb_t3.js gzip N/A 2.29 kB -
0roh390ijzxa5.js gzip N/A 8.75 kB -
0vex9w55ursqj.js gzip N/A 8.79 kB -
13t2aglmqt7v4.js gzip N/A 155 B -
14b85ht2k2zek.js gzip N/A 156 B -
17oe55cu76cd7.js gzip N/A 450 B -
1a5mytgexg-pm.js gzip N/A 160 B -
1d38b08ymu4tx.js gzip N/A 156 B -
1drww5xikb-c-.js gzip N/A 9.46 kB -
1g60xde_dv17t.js gzip N/A 8.79 kB -
1uzv47btzam64.js gzip N/A 5.73 kB -
1vy7n7wxv_rh5.js gzip N/A 8.81 kB -
1wbk4uc1vqzhw.js gzip N/A 156 B -
2-0i7pl900-ou.js gzip N/A 8.71 kB -
2-kcbngm7ik7y.js gzip N/A 8.75 kB -
29p5-xa4jmdhg.js gzip N/A 13.7 kB -
2b06qy4t40pha.js gzip N/A 157 B -
2mr-6hunyw7uo.js gzip N/A 7.53 kB -
2nsrcvgnlgkby.js gzip N/A 3.56 kB -
2ugc69z0t0ypz.js gzip N/A 1.46 kB -
36dn8i-_3dnq5.js gzip N/A 10 kB -
3fljpmwcjxqhx.js gzip N/A 10.3 kB -
3gz44skqdlsrb.js gzip N/A 8.71 kB -
3hnltmd1zltdh.js gzip N/A 154 B -
3hx8satzby5ic.js gzip N/A 156 B -
3j_o58g5hq3jz.js gzip N/A 168 B -
3k_g7nrlaedxq.js gzip N/A 154 B -
3skgwg3_u6i_e.js gzip N/A 13.2 kB -
3tt4y5c9oeg16.js gzip N/A 47 kB -
3v5azqi6gfoyc.js gzip N/A 154 B -
3v60bdyvh1wr_.js gzip N/A 71.7 kB -
3y9tus7kb5su0.js gzip N/A 13.3 kB -
41srmm2lw8_jw.js gzip N/A 65.6 kB -
44dwqzs7ou1vl.js gzip N/A 161 B -
Total 401 kB 401 kB ⚠️ +15 B

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 1.06 kB 1.06 kB ✓
Total 1.06 kB 1.06 kB ✓
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 877 B 877 B ✓
Total 877 B 877 B ✓
Build Cache
Canary PR Change
00000001.sst gzip 14.8 MB 13.5 MB 🟢 1.31 MB (-9%)
00000002.sst gzip 14 MB 12.1 MB 🟢 1.88 MB (-13%)
00000003.sst gzip 12.4 MB 16 MB 🔴 +3.61 MB (+29%)
00000004.sst gzip 14.3 MB 13.9 MB 🟢 400 kB (-3%)
00000005.sst gzip 10.2 MB 10.2 MB 🔴 +17.8 kB (+0%)
00000006.sst gzip 2.8 MB 2.8 MB ✓
00000007.sst gzip 59 B 59 B ✓
00000008.meta gzip 89 B 89 B ✓
00000009.meta gzip 298 kB 298 kB ✓
00000010.meta gzip 298 kB 298 kB ✓
00000011.meta gzip 298 kB 298 kB ✓
00000012.sst gzip 52.4 kB 53 kB 🔴 +606 B (+1%)
00000013.sst gzip 1.83 MB 1.84 MB 🔴 +5.19 kB (+0%)
00000014.sst gzip 59 B 59 B ✓
00000015.meta gzip 116 B 116 B ✓
00000016.meta gzip 328 kB 328 kB ✓
00000017.meta gzip 408 kB 408 kB ✓
00000018.sst gzip 53.2 kB 53.8 kB 🔴 +599 B (+1%)
00000019.sst gzip 1.4 MB 1.4 MB 🟢 4.75 kB (0%)
00000020.sst gzip 59 B 59 B ✓
00000021.meta gzip 116 B 116 B ✓
00000022.meta gzip 328 kB 328 kB ✓
00000023.meta gzip 374 kB 374 kB ✓
00000024.sst gzip 53.2 kB 53.8 kB 🔴 +685 B (+1%)
00000025.sst gzip 1.4 MB 1.4 MB 🟢 3.64 kB (0%)
00000026.sst gzip 59 B 59 B ✓
00000027.meta gzip 116 B 116 B ✓
00000028.meta gzip 328 kB 328 kB ✓
00000029.meta gzip 374 kB 374 kB ✓
00000030.sst gzip 52.5 kB 53.1 kB 🔴 +578 B (+1%)
00000031.sst gzip 1.4 MB 1.4 MB 🟢 3.62 kB (0%)
00000032.sst gzip 59 B 59 B ✓
00000033.meta gzip 116 B 116 B ✓
00000034.meta gzip 328 kB 328 kB ✓
00000035.meta gzip 374 kB 374 kB ✓
00000036.sst gzip 53.2 kB 53.7 kB 🔴 +541 B (+1%)
00000037.sst gzip 1.4 MB 1.4 MB 🟢 3.6 kB (0%)
00000038.sst gzip 59 B 59 B ✓
00000039.meta gzip 116 B 116 B ✓
00000040.meta gzip 328 kB 328 kB ✓
00000041.meta gzip 374 kB 374 kB ✓
CURRENT gzip 94 B 93 B 🟢 1 B (-1%)
LOG gzip 666 B 678 B 🔴 +12 B (+2%)
Total 80.7 MB 80.7 MB ⚠️ +29.6 kB

📦 Webpack

Client

Main Bundles
Canary PR Change
3322-HASH.js gzip 66.1 kB N/A -
4191.HASH.js gzip 169 B N/A -
7920-HASH.js gzip 4.67 kB N/A -
9784-HASH.js gzip 5.63 kB N/A -
b1ad9f4c-HASH.js gzip 63.5 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 253 B 254 B ✓
main-HASH.js gzip 40.2 kB 40.2 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
3577.HASH.js gzip N/A 168 B -
578-HASH.js gzip N/A 66.2 kB -
8590-HASH.js gzip N/A 5.61 kB -
9750-HASH.js gzip N/A 4.68 kB -
a8984546-HASH.js gzip N/A 63.5 kB -
Total 242 kB 242 kB ⚠️ +33 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 193 B ✓
_error-HASH.js gzip 181 B 182 B ✓
css-HASH.js gzip 334 B 331 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 255 B 253 B ✓
head-HASH.js gzip 349 B 351 B ✓
hooks-HASH.js gzip 382 B 384 B ✓
image-HASH.js gzip 581 B 582 B ✓
index-HASH.js gzip 260 B 259 B ✓
link-HASH.js gzip 2.48 kB 2.48 kB ✓
routerDirect..HASH.js gzip 317 B 318 B ✓
script-HASH.js gzip 384 B 386 B ✓
withRouter-HASH.js gzip 316 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.95 kB 7.96 kB ⚠️ +4 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 130 kB 129 kB ✓
page.js gzip 294 kB 294 kB ✓
Total 424 kB 423 kB ✅ -949 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 616 B 617 B ✓
middleware-r..fest.js gzip 156 B 156 B ✓
middleware.js gzip 46.2 kB 45.7 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 47.8 kB 47.4 kB ✅ -428 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 717 B 718 B ✓
Total 717 B 718 B ⚠️ +1 B
Build Cache
Canary PR Change
0.pack gzip 4.83 MB 4.82 MB 🟢 8.9 kB (0%)
index.pack gzip 124 kB 123 kB ✓
index.pack.old gzip 124 kB 124 kB ✓
Total 5.08 MB 5.07 MB ✅ -9.8 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 375 kB 375 kB ✓
app-page-exp..prod.js gzip 207 kB 207 kB ✓
app-page-tur...dev.js gzip 375 kB 375 kB ✓
app-page-tur..prod.js gzip 207 kB 207 kB ✓
app-page-tur...dev.js gzip 371 kB 371 kB ✓
app-page-tur..prod.js gzip 204 kB 204 kB ✓
app-page.run...dev.js gzip 371 kB 371 kB ✓
app-page.run..prod.js gzip 205 kB 205 kB ✓
app-route-ex...dev.js gzip 83.3 kB 83.3 kB ✓
app-route-ex..prod.js gzip 56.3 kB 56.3 kB ✓
app-route-tu...dev.js gzip 83.4 kB 83.4 kB ✓
app-route-tu..prod.js gzip 56.3 kB 56.3 kB ✓
app-route-tu...dev.js gzip 82.9 kB 82.9 kB ✓
app-route-tu..prod.js gzip 56.1 kB 56.1 kB ✓
app-route.ru...dev.js gzip 82.9 kB 82.9 kB ✓
app-route.ru..prod.js gzip 56.1 kB 56.1 kB ✓
dev-validati...dev.js gzip 134 kB 134 kB ✓
dev-validati...dev.js gzip 134 kB 134 kB ✓
dev-validati...dev.js gzip 132 kB 132 kB ✓
dev-validati...dev.js gzip 132 kB 132 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 46.5 kB 46.5 kB ✓
pages-api-tu..prod.js gzip 34.7 kB 34.7 kB ✓
pages-api.ru...dev.js gzip 46.5 kB 46.5 kB ✓
pages-api.ru..prod.js gzip 34.6 kB 34.6 kB ✓
pages-turbo....dev.js gzip 55.3 kB 55.3 kB ✓
pages-turbo...prod.js gzip 40.2 kB 40.2 kB ✓
pages.runtim...dev.js gzip 55.3 kB 55.3 kB ✓
pages.runtim..prod.js gzip 40.2 kB 40.2 kB ✓
server.runti..prod.js gzip 66.7 kB 66.7 kB ✓
use-cache-pr...dev.js gzip 72.8 kB 72.8 kB ✓
use-cache-pr...dev.js gzip 72.8 kB 72.8 kB ✓
use-cache-pr...dev.js gzip 71 kB 71 kB ✓
use-cache-pr...dev.js gzip 71 kB 71 kB ✓
Total 4.11 MB 4.11 MB ⚠️ +1 B
📎 Tarball URL 
https://vercel-packages.vercel.app/next/commits/86fba56ae814567abf661dbb71c40d4c5195d3e4/next

Commit: 86fba56

@mischnic mischnic changed the title remove unused props from getPagesPageStaticInfo Remove unused return values from getPageStaticInfo Aug 21, 2026
@mischnic
mischnic marked this pull request as ready for review August 21, 2026 06:45
@mischnic
mischnic requested a review from timneutkens August 21, 2026 07:18
dianatofficial
dianatofficial reviewed Aug 22, 2026
View reviewed changes

@dianatofficial dianatofficial left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean implementation. Types and docs are up to date.

@mischnic
mischnic merged commit a1cc1ea into canary Aug 24, 2026
233 of 235 checks passed
@mischnic
mischnic deleted the mischnic/cleanup-getPagesPageStaticInfo branch August 24, 2026 10:05
@github-actions github-actions Bot added the locked label Sep 7, 2026
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timneutkens timneutkens timneutkens approved these changes
+1 more reviewer
@dianatofficial dianatofficial dianatofficial left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

locked

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mischnic @timneutkens @dianatofficial