Skip to content

Clarify verbose messaging and print control - #29

Merged
vertesy merged 11 commits into
mainfrom
codex/analyze-function-arguments-for-issues
Aug 27, 2026
Merged

Clarify verbose messaging and print control#29
vertesy merged 11 commits into
mainfrom
codex/analyze-function-arguments-for-issues

Conversation

@vertesy

@vertesy vertesy commented Dec 2, 2025

Copy link
Copy Markdown
Owner

Summary

  • clarify get_max_colname_per_row suffix documentation to reflect verbose message use
  • make get_col_types respect the print_it flag for both table and summary output

Testing

  • Not run (R is not available in the execution environment)

Codex Task

Base automatically changed from dev to main December 2, 2025 19:20
@vertesy
vertesy requested a balanced review from Copilot August 27, 2026 17:02
@vertesy

vertesy commented Aug 27, 2026

Copy link
Copy Markdown
Owner Author

@copilot resolve the merge conflicts in this pull request.

This is a very old PR - unclear how much of it is really needed and relevant. Some part may totally be outdated by now.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Tie handling can return incorrect result lengths, and several generated documentation files are inconsistent with their roxygen sources.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates output controls and documentation across the R utility package, while also introducing validation and behavior changes.

Changes:

  • Makes get_col_types() and fix_tibble_lists() respect print controls.
  • Revises maximum-column and percentile-clipping behavior.
  • Cleans up documentation, validation, and logical operators.
File summaries
File Description
R/CodeAndRoll2.R Updates utility behavior, validation, messaging, and documentation.
README.md Corrects catalogue wording and spelling.
man/get_max_colname_per_row.Rd Clarifies suffix documentation.
man/splititsnames_byValues.Rd Corrects duplicated wording.
man/as.numeric.wNames.character.Rd Corrects conversion documentation.
man/as.named.vector.2colDF.Rd Uses the full logical constant name.
man/as_tibble_from_namedVec.Rd Uses the full logical constant name.
Development/zacc/oxy-CodeAndRoll2.orig.R Corrects a comment typo.
Development/zacc/CodeAndRoll2.orig.R Corrects a comment typo.
AGENTS.md Adds repository development guidance.
Review details

Files not reviewed (5)

  • man/as.named.vector.2colDF.Rd: Generated file
  • man/as.numeric.wNames.character.Rd: Generated file
  • man/as_tibble_from_namedVec.Rd: Generated file
  • man/get_max_colname_per_row.Rd: Generated file
  • man/splititsnames_byValues.Rd: Generated file
  • Files reviewed: 5/10 changed files
  • Comments generated: 8
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread R/CodeAndRoll2.R Outdated
Comment thread R/CodeAndRoll2.R Outdated
Comment thread R/CodeAndRoll2.R Outdated
Comment thread man/as.numeric.wNames.character.Rd Outdated
Comment thread man/splititsnames_byValues.Rd
Comment thread R/CodeAndRoll2.R Outdated
Comment thread R/CodeAndRoll2.R Outdated
Comment thread R/CodeAndRoll2.R
Co-authored-by: vertesy <5101911+vertesy@users.noreply.github.com>

Copilot AI commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request.

This is a very old PR - unclear how much of it is really needed and relevant. Some part may totally be outdated by now.
...

Merge conflicts resolved. I took origin/main for AGENTS.md, README.md, and the .Rd file, and for R/CodeAndRoll2.R I used origin/main's formatting/signatures throughout while preserving the PR's core changes: the fix_tibble_lists verbose-gated cat() and get_col_types print control fix.

This validation accepts high = NA, but isTRUE(NA) below silently takes the lower-clipping branch. Reject NA so an indeterminate direction cannot produce a valid-looking but incorrect result.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…ail clipping)

Co-authored-by: vertesy <5101911+vertesy@users.noreply.github.com>
… reflect collapse-first tie behavior

Co-authored-by: vertesy <5101911+vertesy@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@vertesy
vertesy merged commit 9e4ee27 into main Aug 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants