Clarify verbose messaging and print control - #29
Conversation
|
@copilot resolve the merge conflicts in this pull request. This is a very old PR - unclear how much of it is really needed and relevant. Some part may totally be outdated by now. |
There was a problem hiding this comment.
🟡 Changes recommended
Tie handling can return incorrect result lengths, and several generated documentation files are inconsistent with their roxygen sources.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates output controls and documentation across the R utility package, while also introducing validation and behavior changes.
Changes:
- Makes
get_col_types()andfix_tibble_lists()respect print controls. - Revises maximum-column and percentile-clipping behavior.
- Cleans up documentation, validation, and logical operators.
File summaries
| File | Description |
|---|---|
R/CodeAndRoll2.R |
Updates utility behavior, validation, messaging, and documentation. |
README.md |
Corrects catalogue wording and spelling. |
man/get_max_colname_per_row.Rd |
Clarifies suffix documentation. |
man/splititsnames_byValues.Rd |
Corrects duplicated wording. |
man/as.numeric.wNames.character.Rd |
Corrects conversion documentation. |
man/as.named.vector.2colDF.Rd |
Uses the full logical constant name. |
man/as_tibble_from_namedVec.Rd |
Uses the full logical constant name. |
Development/zacc/oxy-CodeAndRoll2.orig.R |
Corrects a comment typo. |
Development/zacc/CodeAndRoll2.orig.R |
Corrects a comment typo. |
AGENTS.md |
Adds repository development guidance. |
Review details
Files not reviewed (5)
- man/as.named.vector.2colDF.Rd: Generated file
- man/as.numeric.wNames.character.Rd: Generated file
- man/as_tibble_from_namedVec.Rd: Generated file
- man/get_max_colname_per_row.Rd: Generated file
- man/splititsnames_byValues.Rd: Generated file
- Files reviewed: 5/10 changed files
- Comments generated: 8
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: vertesy <5101911+vertesy@users.noreply.github.com>
Merge conflicts resolved. I took |
This validation accepts high = NA, but isTRUE(NA) below silently takes the lower-clipping branch. Reject NA so an indeterminate direction cannot produce a valid-looking but incorrect result. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…ail clipping) Co-authored-by: vertesy <5101911+vertesy@users.noreply.github.com>
… reflect collapse-first tie behavior Co-authored-by: vertesy <5101911+vertesy@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Summary
Testing
Codex Task