Conversation
Updated installation instructions and added notes about the 'qs' dependency issues on Windows.
|
@copilot |
|
@vertesy I can’t apply these changes because the pull request’s branch is the repository’s default branch, which I’m not allowed to push to directly. You can ask me to create a new pull request with the requested changes instead and I'll open a separate PR on a new branch. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a6e50c876d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| read_in <- as.data.frame(gtools::na.replace(read_in, replace = 0)) | ||
| } | ||
|
|
||
| if (wRownames) read_in <- column.2.row.names(read_in, as_df = !asTibble) |
There was a problem hiding this comment.
asTibble lookup
With the default wRownames = TRUE, every successful SSV read evaluates !asTibble, but read.simple.ssv() neither declares that parameter nor defines the variable. Normal callers therefore get object 'asTibble' not found instead of their data; add the parameter explicitly or retain the previous data-frame conversion behavior.
Useful? React with 👍 / 👎.
| manual_directory = manual_directory | ||
| ) | ||
|
|
||
| dir.create(dirname(FnP), recursive = TRUE, showWarnings = FALSE) |
There was a problem hiding this comment.
When manual_directory names a directory that does not exist yet, construct.file.path() now stops at its dir.exists(out_dir) assertion, so execution can never reach this recursive dir.create() call. Create the directory before constructing the path, or allow the constructor to return paths under not-yet-created directories.
Useful? React with 👍 / 👎.
| write.simple.vec <- function(input_vec, filename = substitute(input_vec), suffix = NULL, extension = "vec", | ||
| manual_file_name = NULL, manual_directory = NULL, o = FALSE, | ||
| make_names = TRUE, manual_file_name = NULL, manual_directory = NULL, o = FALSE, | ||
| v = TRUE) { |
There was a problem hiding this comment.
make_names
Existing callers that pass manual_file_name as the fifth positional argument now bind that filename to make_names; the subsequent if (make_names) then receives a character value and errors. Add the new option after the existing parameters so the established positional API continues to work.
Useful? React with 👍 / 👎.
| o = FALSE, gzip = FALSE, | ||
| TabColor = "darkgoldenrod1", HeaderLineColor = "darkolivegreen3", |
There was a problem hiding this comment.
gzip
For existing positional calls, the eighth argument previously configured TabColor but now binds to gzip, while every later styling argument is shifted as well. A color string ultimately reaches if (gzip) and causes an error after writing the workbook; append the new option after the existing arguments or otherwise preserve their positions.
Useful? React with 👍 / 👎.
No description provided.