Skip to content

ARC-3876: add aria label to image grid item #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reunefe merged 2 commits into from
Sep 8, 2026
+42 −17
Merged

ARC-3876: add aria label to image grid item #450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dec911a
ARC-3876: add aria label to image grid item
reunefe Sep 3, 2026
c8d44d0
Merge branch 'release/v6.0.0' into bugfix/ARC-3876_translation-label
reunefe Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 37 additions & 16 deletions ui/src/react-admin/modules/content-page/components/blocks/BlockImageGrid/BlockImageGrid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ import { defaultRenderLinkFunction } from '~shared/helpers/routing/link';

import './BlockImageGrid.scss';
import { CopyrightAttribution } from '~shared/components/CopyrightAttribution';
import { generateSmartLink } from '~shared/components/SmartLink/SmartLink.tsx';
import { tText } from '~shared/helpers/translation-functions.ts';

export const BlockImageGrid: FunctionComponent<BlockImageGridProps> = ({
elements = [],
Expand Down Expand Up @@ -111,22 +113,41 @@ export const BlockImageGrid: FunctionComponent<BlockImageGridProps> = ({
<div
className={clsx('c-block-grid', `text-align-${textAlign}`, `item-align-${align}`, className)}
>
{elements.map((element, index) => (
<div
key={`block-grid-${element?.action?.value || element.title || null}${index}`}
className={clsx('c-block-grid__item')}
style={{
width: itemWidth,
margin: `${Math.round(verticalMargin / 2)}px ${Math.round(horizontalMargin / 2)}px`,
}}
>
{renderLink(
element.action,
renderGridImage(element),
element.title || element.buttonTitle || element.titleAbove
)}
</div>
))}
{elements.map((element, index) => {
const title = element.title || element.buttonTitle || element.titleAbove || '';
let elementAriaLabel: string;

if (element.imageLabel?.text) {
elementAriaLabel = tText('aria-label block image grid item met label', {
label: element.imageLabel.text,
title,
});
} else {
elementAriaLabel = tText('aria-label block image grid item', {
title,
});
}

return (
<div
key={`block-grid-${element?.action?.value || element.title || null}${index}`}
className={clsx('c-block-grid__item')}
style={{
width: itemWidth,
margin: `${Math.round(verticalMargin / 2)}px ${Math.round(horizontalMargin / 2)}px`,
}}
>
{generateSmartLink(
element.action,
renderGridImage(element),
title,
undefined,
undefined,
elementAriaLabel
)}
</div>
);
})}
</div>
);
};
6 changes: 5 additions & 1 deletion ui/src/react-admin/modules/shared/components/SmartLink/SmartLink.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ export const SmartLink: FunctionComponent<SmartLinkProps> = ({
target={LinkTarget.Blank}
rel="noopener noreferrer"
title={title}
aria-label={ariaLabel}
className={clsx(className, { 'a-link__no-styles': removeStyles })}
onClick={() => AdminConfigManager.getConfig().handlers.onExternalLink(fullUrl)}
onKeyUp={onKeyUpHandler}
Expand All @@ -150,6 +151,7 @@ export const SmartLink: FunctionComponent<SmartLinkProps> = ({
target={LinkTarget.Blank}
rel="noopener noreferrer"
title={title}
aria-label={ariaLabel}
className={clsx(className, { 'a-link__no-styles': removeStyles })}
onClick={() => AdminConfigManager.getConfig().handlers.onExternalLink(fullUrl)}
onKeyUp={onKeyUpHandler}
Expand Down Expand Up @@ -284,7 +286,8 @@ export const generateSmartLink = (
children: ReactNode,
title?: string,
className?: string,
tabIndex?: number
tabIndex?: number,
ariaLabel?: string
// biome-ignore lint/suspicious/noExplicitAny: todo
): ReactElement<any, any> | null => {
return (
Expand All @@ -294,6 +297,7 @@ export const generateSmartLink = (
className={className}
key={`smart-link-${action?.value}-${title}-${className}`}
tabIndex={tabIndex}
ariaLabel={ariaLabel}
>
{children}
</SmartLink>
Expand Down