Feature/arc 3904 video player - #150
Open
reunefe wants to merge 12 commits into
Open
Conversation
bertyhell
approved these changes
Sep 7, 2026
| @@ -0,0 +1,75 @@ | |||
| export type AudioWaveFormDisplaySize = 'small' | 'large'; | |||
Contributor
There was a problem hiding this comment.
i always prefer enums, since that links the usage and types together
'small' vs AudioWaveFormDisplaySize.Small
it's easier to search for occurances for the latter
|
|
||
| import './ControlBar.scss'; | ||
|
|
||
| type FlyoutId = 'subtitles' | 'speed'; |
Comment on lines
+23
to
+35
| export const defaultControlsLabels: Required<FlowPlayerControlsLabels> = { | ||
| play: 'Afspelen', | ||
| pause: 'Pauzeren', | ||
| mute: 'Dempen', | ||
| unmute: 'Dempen opheffen', | ||
| volume: 'Volume', | ||
| fullscreenEnter: 'Volledig scherm', | ||
| fullscreenExit: 'Volledig scherm sluiten', | ||
| subtitles: 'Ondertitels', | ||
| subtitlesOff: 'Uit', | ||
| speed: 'Snelheid', | ||
| progressBar: 'Voortgang', | ||
| }; |
Contributor
There was a problem hiding this comment.
do we want the client to manage the translations or the component library?
for the rich text we allow the locale to be set
and the labels are hardcoded in the component:
We should use the same mechanism, or also switch the rich text to this mechanism
i kind of like the simplicity of only passing the locale
| // meaning, just applied to this visual instead of the canvas; `active`/`inactive` are revealed | ||
| // via the same clip-path progress technique already used for the progress bar's own light/dark | ||
| // label overlay. | ||
| peakMode?: 'data' | 'generic'; // default 'data' |
Contributor
There was a problem hiding this comment.
do we need this?
can't we just have a property: peakData?: any[];
and show the generic when it's undefined?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.