Repository navigation
fix: show sandbox failure details and explain polling timeouts - #107
Open
lalit-videodb wants to merge 1 commit into
Open
lalit-videodb wants to merge 1 commit into
lalit-videodb wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description:
Sandbox polling currently drops the API's
errorfield and reports only that a terminal state was reached. A polling timeout also gives no guidance that startup may continue. Preserve the error onsandbox.error, include it in terminal exceptions, and tell callers they can continue waiting on the same sandbox ID after a timeout.Changes:
Related Issues:
Follow-up from repeated sandbox startup failures; independent of the infrastructure repair and requires no server changes. This PR does not publish a package or change the existing client's notebook.
Testing:
All 16 tests pass, including 12 new sandbox cases. Full-repository Ruff check and diff checks pass. Independent review reran the tests and checked create/get/list constructor propagation. Covers missing/null errors, terminal details, existing fallback text, ready states, and timeout followed by successful waiting on the same ID.