Skip to content

fix: silence PDOStatement::setFetchMode signature notice on PHP 8 #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rtm-ctrlz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: silence PDOStatement::setFetchMode signature notice on PHP 8 #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/FakePdoStatementTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,7 @@ function ($row) use ($fetch_argument, $ctor_args) {
/**
* @param int $fetch_style
* @param mixed $args
* @return true
*/
public function universalSetFetchMode(int $mode, ...$args) : bool
{
Expand Down
2 changes: 2 additions & 0 deletions src/Php8/FakePdoStatement.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ public function fetchAll(int $fetch_style = -123, ...$args) : array
/**
* @param int $fetch_style
* @param mixed $args
* @return true
*/
#[\ReturnTypeWillChange]
public function setFetchMode(int $mode, ...$args) : bool
{
return $this->universalSetFetchMode($mode, ...$args);
Expand Down
15 changes: 15 additions & 0 deletions tests/FakePdoTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,21 @@ public function testMinimalTransaction(): void
self::assertFalse($pdo->inTransaction());
}

public function testSetFetchMode(): void
{
$pdo = self::getPdo('mysql:foo;dbname=test;');
$pdo->prepare('CREATE TABLE `foo` (`id` INT NOT NULL, PRIMARY KEY (`id`)) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_general_ci')->execute();
$pdo->prepare('INSERT INTO `foo` (`id`) VALUES (1)')->execute();

$statement = $pdo->prepare('SELECT `id` FROM `foo`');

self::assertTrue($statement->setFetchMode(\PDO::FETCH_ASSOC));

$statement->execute();

self::assertSame([['id' => '1']], $statement->fetchAll());
}

/**
* @dataProvider quotationStringProvider
*/
Expand Down
Loading