Conversation
tsimonq2
requested review from
DGonzalezVillal,
larrydewey and
tylerfanelli
as code owners
September 11, 2026 15:37
tylerfanelli
requested changes
Sep 15, 2026
tylerfanelli
left a comment
Member
There was a problem hiding this comment.
Would you mind running cargo fmt on the commit, as well as adding another commit addressing the clippy test failures.
Can you also add a Signed-off-by line to each commit?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am packaging the sev crate for Debian.
The attached patch ports to iocuddle 0.3, and is somewhat hacky, but it compiles and seems to work.
Feel free to fix up and merge, merge as-is, or let me know if you'd like me to make changes.
Thanks!