fix: malformed Darwin linker flags for libvdehist - #79
Merged
Merged
Conversation
-Wl,-force_load without an archive path consumed the next linker argument, so MacPorts builds failed with "library '-headerpad_max_install_names' not found". Only -undefined,dynamic_lookup is actually required (libvdehist has an unresolved _prompt symbol on macOS); drop the rest so the build environment provides its own optimization, debug, PIC and install-name flags. The existing macos-latest CI job exercises this. Fixes #71.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused change matches the issue’s verified fix without introducing unresolved concerns.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes malformed macOS linker flags for libvdehist while preserving unresolved-symbol handling.
Changes:
- Removes unnecessary Darwin compile/link flags.
- Uses the valid
-Wl,-undefined,dynamic_lookupoption.
| File | Description |
|---|---|
src/lib/CMakeLists.txt |
Corrects Darwin linker configuration for vdehist. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
rd235
approved these changes
Oct 3, 2026
rd235
left a comment
rd235
left a comment
Member
There was a problem hiding this comment.
CI tools should have confirmed the cmake options for Darwin. ok.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #71
Apply the reduced Darwin flags proposed by the reporter.
Note: the macOS job is already present in the ci.yml matrix, so no CI change
was needed (deviation from the original plan).
Verified: host build passes.