fix: NUL-terminate config_readline() when the file lacks a final newline - #81
Merged
Merged
Conversation
If read() returns EOF in the middle of a line, the loop exited without terminating the buffer and the caller passed an unterminated string to handle_cmd(). Terminate it before returning; the len == MAXCMD truncation path already zeroed the last byte. Fixes #63.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused change correctly prevents stale buffer contents from affecting the final configuration command.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes parsing of configuration files whose final line lacks a newline.
Changes:
- NUL-terminates partially read final configuration lines.
- Preserves existing handling for full buffers and newline-terminated lines.
| File | Description |
|---|---|
src/vde_router/vde_router.c |
Ensures config_readline() returns a terminated string at EOF. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #63
vde_router.c:1385: the config_readline() buffer was not NUL-terminated when EOF
was reached mid-line, so the router config reader could see a garbage tail.
Verified: host build passes.