fix(ui): align vite and rolldown home banner spacing - #536
Merged
Conversation
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes the home-page “hero” (banner) vertical spacing between the Vite and Rolldown UIs by extracting the shared layout into a reusable UI component in @vitejs/devtools-ui.
Changes:
- Introduces a shared
ContainerHomeHerocomponent to provide consistent header padding/alignment for home banners. - Updates the Vite home page to wrap its banner with
ContainerHomeHeroand align outer padding with Rolldown. - Updates the Rolldown home page to use the same
ContainerHomeHerowrapper, ensuring consistent spacing across both apps.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/vite/src/app/pages/home.vue | Switches the home hero section to use the shared ContainerHomeHero wrapper and aligns page padding. |
| packages/ui/src/components/Container/ContainerHomeHero.vue | Adds the shared home hero container that defines consistent banner spacing/alignment. |
| packages/ui/src/components/Container/ContainerHomeHero.stories.ts | Adds Storybook coverage for the new container (default + secondary content scenarios). |
| packages/rolldown/src/app/pages/index.vue | Wraps the Rolldown banner with ContainerHomeHero and aligns outer padding to match Vite. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screenshot: