Skip to content

fix(ui): align vite and rolldown home banner spacing - #536

Merged
antfu merged 1 commit into
mainfrom
fix/unify-home-banner-spacing
Aug 20, 2026
Merged

fix(ui): align vite and rolldown home banner spacing#536
antfu merged 1 commit into
mainfrom
fix/unify-home-banner-spacing

Conversation

@webfansplz

Copy link
Copy Markdown
Member

Screenshot:

image

Copilot AI lite review requested due to automatic review settings August 19, 2026 10:18
@pkg-pr-new

pkg-pr-new Bot commented Aug 19, 2026

Copy link
Copy Markdown

Open in StackBlitz

@vitejs/devtools

npm i https://pkg.pr.new/@vitejs/devtools@536

@vitejs/devtools-kit

npm i https://pkg.pr.new/@vitejs/devtools-kit@536

@vitejs/devtools-oxc

npm i https://pkg.pr.new/@vitejs/devtools-oxc@536

@vitejs/devtools-rolldown

npm i https://pkg.pr.new/@vitejs/devtools-rolldown@536

@vitejs/devtools-vite

npm i https://pkg.pr.new/@vitejs/devtools-vite@536

@vitejs/devtools-vitest

npm i https://pkg.pr.new/@vitejs/devtools-vitest@536

commit: 0095cba

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes the home-page “hero” (banner) vertical spacing between the Vite and Rolldown UIs by extracting the shared layout into a reusable UI component in @vitejs/devtools-ui.

Changes:

  • Introduces a shared ContainerHomeHero component to provide consistent header padding/alignment for home banners.
  • Updates the Vite home page to wrap its banner with ContainerHomeHero and align outer padding with Rolldown.
  • Updates the Rolldown home page to use the same ContainerHomeHero wrapper, ensuring consistent spacing across both apps.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/vite/src/app/pages/home.vue Switches the home hero section to use the shared ContainerHomeHero wrapper and aligns page padding.
packages/ui/src/components/Container/ContainerHomeHero.vue Adds the shared home hero container that defines consistent banner spacing/alignment.
packages/ui/src/components/Container/ContainerHomeHero.stories.ts Adds Storybook coverage for the new container (default + secondary content scenarios).
packages/rolldown/src/app/pages/index.vue Wraps the Rolldown banner with ContainerHomeHero and aligns outer padding to match Vite.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@antfu
antfu merged commit 66bd09a into main Aug 20, 2026
11 checks passed
@antfu
antfu deleted the fix/unify-home-banner-spacing branch August 20, 2026 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants