Repository navigation
fix: add upm to package-count and process-count collectors - #180
Conversation
The upm package manager was added to benchmarks but its count file
entries were missing from collect-package-count.js and
collect-process-count.js. This caused:
- package-count.sh correctly writes upm-count.txt
- collect-package-count.js didn't read it → no package count data
- generate-chart.js couldn't compute per-package times for upm
- Leaderboard cards and per-fixture charts (which use per-package data)
excluded upm, while the total-time histogram (which uses raw data)
showed it correctly
Add the missing { filename: 'upm-count.txt', pmName: 'upm' } entry to
both collector scripts.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe package-count and process-count collectors now include UPM count files in their existing collection flows. Both files map to the ChangesUPM Count Collection
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The change connects UPM count files to the existing collection flows, enabling their counts to appear in package and process results. No actionable merge risk remains from the reviewed changes. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
The
upmpackage manager was added to benchmarks in #177 but its count file entries were missing from the collector scripts. This causedupmto appear inconsistently on benchmarks.vlt.sh:chartData)perPackageCountChartData)Root Cause
The data pipeline for per-package metrics works as follows:
package-count.shruns after each benchmark → correctly detectsupm.lockand writesupm-count.txt✅collect-package-count.jsreads*-count.txtfiles intopackage-count.json→ missingupm-count.txtentry ❌generate-chart.jsuses package counts to compute per-package times → no count for upm → no per-package dataSame issue exists in
collect-process-count.jsfor spawned process counts.Fix
Add the missing entries:
{ filename: 'upm-count.txt', pmName: 'upm' }tocollect-package-count.js{ filename: 'upm-process-count.txt', pmName: 'upm' }tocollect-process-count.jsThe next benchmark run on
mainwill produce correct per-package data for upm, and it will appear in all views.Summary by CodeRabbit