Repository navigation
fix: add --allow-scripts for bun/deno in npm v11 - #182
Conversation
npm v11 blocks dependency lifecycle scripts by default. bun and deno both use postinstall scripts to download platform-specific binaries, so they need --allow-scripts to work. Changes: - scripts/variations/ci+setup.sh: Add --allow-scripts=bun and --allow-scripts=deno to SETUP_INSTALL_BUN and SETUP_INSTALL_DENO - scripts/setup.sh: Add --allow-scripts=bun,deno,nx to the main npm install -g line (latent bug masked by runner image having these pre-installed)
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughGlobal tool installation commands now allow lifecycle scripts for Bun, Deno, and Nx. The Bun and Deno variation commands allow scripts for their respective packages. ChangesInstall script permissions
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The selected install scripts are permitted while benchmark fixture installs remain script-disabled; no actionable merge-blocking risk is established. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The change requests script permission for named tools rather than enabling all installation scripts. Fixture-script restrictions remain intact. Installer execution occurs within an existing third-party tool trust boundary, but exact npm enforcement and interrupted-install recovery are not fully established. Retained concerns Security review detailsSecurity Blast Radius
Security Findings and Attack Paths
Trust Boundaries and Controls
Resilience and Maintainability Implications
Hardening Proposals
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
npm v11 blocks dependency lifecycle scripts by default. bun and deno both use postinstall scripts to download their platform-specific binaries, so
npm install -g bun@latestandnpm install -g deno@latestsilently fail to install the actual binaries — causing exit code 1 in all ci+setup benchmark fixtures.Fix
scripts/variations/ci+setup.sh--allow-scripts=buntoSETUP_INSTALL_BUN--allow-scripts=denotoSETUP_INSTALL_DENOscripts/setup.sh--allow-scripts=bun,deno,nxto the mainnpm install -gline (latent bug masked by the CI runner image having these tools pre-installed)Context
This matches the pattern already used for pacquet (
--allow-scripts=pnpm) and aube (--allow-scripts=@endevco/aube) in the same files.Summary by CodeRabbit