Repository navigation
feat: add profiles.check (spec 1.26.0) - #82
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts spec 1.26.0. Additive and non-breaking (check-types clean, tests pass).
client.profiles.check({ profile: { text }, credentials? })wraps the newPOST /v1/simc/profiles/check: it checks profile text against the rulesjobs.createapplies, without creating a job or using credits. A pass resolves with the inputwarningsandwarningsCount; a rejection throws the sameInvalidProfileError/TooManyVariantsErrora submission would. Adds theProfilesresource andProfileCheckParams/ProfileCheckResponse. Sends no idempotency key, since a repeat check has no side effects.InvalidProfileError.meta.blocked[]entries gaindirectiveandmessage.warningsCount(warningsnow lists the first 16), and the profile and request body limits rise to 5 MB and 6 MB. These flow through the generated types; the README size note is updated to match.DESIGN.md updated to revision 2.16. Releases as 0.16.0.