Skip to content

test(agents): keep the image PATH in the setup-gate profile fixtures - #72

Merged
tee8z merged 1 commit into
mainfrom
fix/agent-image-gate-test-path
Oct 22, 2026
Merged

tee8z merged 1 commit into
mainfrom
fix/agent-image-gate-test-path

Conversation

@tee8z

@tee8z tee8z commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

What

test-profile.py has failed its manual-gate mode since buzz #71, with "profile did not reach the account gate". The image itself is fine. The failure comes from the fixture:

Fix

  • The two gate modes (manual-gate, gate-api-key) keep the image's PATH.
  • manual-gate also rotates the fixture profile to a via profile without a depot service, so its bootstrap never calls the image's op against the emulated network. The other modes still read Depot through the fake op.

Tested

I ran the full test-profile.py locally against the published main image (voltage-buzz-agent-staging@sha256:c7bc5ad9…2547, from f87d8c981). Every mode passes, including manual-gate: "rotated shared profile with a Claude subscription token reaches manual account-login gate".

Summary by CodeRabbit

  • Tests
    • Updated profile test fixtures to preserve the image’s exact PATH in selected modes and cover profile rotation with a subscription token and without a Depot service. The API-key mode is also covered without profile rotation. These changes affect test coverage only; no end-user behavior changes are noted.

The Codex setup gate requires the image's exact PATH, so manual-gate
failed once the fixture prepended a fake op for the vault's Depot read.
Keep PATH in the gate modes, and drop the depot service from the
manual-gate profile so its bootstrap never calls op.
@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between f87d8c9 and 0b5eb8c.

📒 Files selected for processing: 1
  • voltage/images/buzz-agent/test-profile.py

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

📝 Walkthrough

The test fixture preserves the image’s PATH in manual-gate and gate-api-key modes. In manual-gate mode, rotation sets a Claude subscription token and a provider configuration without a Depot service. In gate-api-key mode, rotation remains skipped.

Changes: Gate profile fixture

Layer / File(s) Summary
Gate-mode fixture setup
voltage/images/buzz-agent/test-profile.py
Fake account tools are added to PATH except in manual-gate and gate-api-key modes. Rotation can replace via.profile; the manual-gate profile uses a Claude subscription token and has no Depot service. Gate-api-key mode skips rotation.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

  • voltagecloud/buzz#71: Changes the profile contract that this fixture exercises, including Depot credentials, Claude subscription credentials, and Codex setup-gate behavior.

Suggested reviewers: thebrandonlucas

Merge Risk: ⚪ Minimal · up to 0b5eb

No actionable merge-blocking risk is established by the fixture changes.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: preserving the image PATH in the setup-gate profile fixtures.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@tee8z tee8z self-assigned this Oct 22, 2026
@tee8z
tee8z requested a review from thebrandonlucas October 22, 2026 20:04
@tee8z
tee8z merged commit 05c6793 into main Oct 22, 2026
40 checks passed
@tee8z
tee8z deleted the fix/agent-image-gate-test-path branch October 22, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants