Skip to content

Repository navigation

fix(gpui): load older thread replies after the list releases its state #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thebrandonlucas merged 3 commits into from
Oct 29, 2026
Merged

fix(gpui): load older thread replies after the list releases its state #91

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2189ee
fix(gpui): load older thread replies after the list releases its state
thebrandonlucas Oct 28, 2026
4c9bc32
Merge fix/gpui-read-buzz-app-identity into fix/gpui-thread-scroll-crash
thebrandonlucas Oct 29, 2026
cf26705
Merge fix/gpui-read-buzz-app-identity into fix/gpui-thread-scroll-crash
thebrandonlucas Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion apps/buzz-gpui/crates/app/src/ui/thread.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,12 @@ impl ThreadPanel {
let weak = cx.entity().downgrade();
list.set_scroll_handler(move |event, _, cx| {
if event.visible_range.start < LOAD_OLDER_WITHIN && event.is_scrolled {
let _ = weak.update(cx, |this, _| this.load_older());
// GPUI runs this while it holds the list's state, and
// load_older reads and changes that state; run it after.
let weak = weak.clone();
cx.defer(move |cx| {
let _ = weak.update(cx, |this, _| this.load_older());
});
}
});
let tasks = vec![
Expand Down
Loading