Repository navigation
feat(cli): show each wallet's currency in the picker #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thebrandonlucas
merged 1 commit into
feat/cli-next-step-after-accept
from
feat/cli-picker-currency
Oct 21, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -124,24 +124,35 @@ impl Drop for PickerScreen { | |||||||||
| pub struct Choice { | ||||||||||
| id: Uuid, | ||||||||||
| name: String, | ||||||||||
| currency: Option<String>, | ||||||||||
| } | ||||||||||
|
|
||||||||||
| impl Choice { | ||||||||||
| pub fn new(id: Uuid, name: &str) -> Self { | ||||||||||
| Self { | ||||||||||
| id, | ||||||||||
| name: scrub_line(name), | ||||||||||
| currency: None, | ||||||||||
| } | ||||||||||
| } | ||||||||||
|
|
||||||||||
| /// Show a wallet's currency between its name and ID, where typing can filter on it. | ||||||||||
| pub fn with_currency(mut self, currency: &str) -> Self { | ||||||||||
| self.currency = Some(scrub_line(¤cy.to_uppercase())); | ||||||||||
|
Comment on lines
+140
to
+141
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Taking the
Suggested change
|
||||||||||
| self | ||||||||||
| } | ||||||||||
|
|
||||||||||
| pub fn name(&self) -> &str { | ||||||||||
| &self.name | ||||||||||
| } | ||||||||||
| } | ||||||||||
|
|
||||||||||
| impl Display for Choice { | ||||||||||
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | ||||||||||
| write!(f, "{} {}", self.name, self.id) | ||||||||||
| match &self.currency { | ||||||||||
| Some(currency) => write!(f, "{} {currency} {}", self.name, self.id), | ||||||||||
| None => write!(f, "{} {}", self.name, self.id), | ||||||||||
| } | ||||||||||
| } | ||||||||||
| } | ||||||||||
|
|
||||||||||
|
|
||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With
with_currencytaking anOption(seeterminal.rs), thematchgoes away: