Repository navigation
feat(cli): accept --all on lists that return every item at once - #94
Merged
thebrandonlucas merged 1 commit intoOct 22, 2026
Merged
Conversation
thebrandonlucas
marked this pull request as ready for review
October 22, 2026 19:42
5 tasks done
thebrandonlucas
force-pushed
the
feat/cli-list-all-hint
branch
from
October 22, 2026 20:33
2ae32e0 to
980dac6
Compare
thebrandonlucas
force-pushed
the
feat/cli-list-all-hint
branch
from
October 22, 2026 21:14
980dac6 to
30481de
Compare
tee8z
approved these changes
Oct 22, 2026
tee8z
left a comment
Contributor
There was a problem hiding this comment.
Approved 30481de against feat/cli-wallet-flag-as-id (#93 b3df4d0). The patch matches 980dac6, and only the CHANGELOG context changed in the rebase.
lists_everything_at_oncematches the contract. The fourlistoperations without alimitparameter (wallets,webhooks,assets,credit-lines) each return a whole array and take no other paging parameter, so--allhas nothing to page. Its help says it has no effect.- A paged list still sets
all, and a non-list such aswallets get --allis still rejected. The tests cover all three cases.
Validation: on 980dac6, the same patch, the full gate passed in nix develop (140 unit, 122 integration), and CRAP measured 630 functions with none at or above 20 (highest wait_for_payment at 19.60). On this head, cargo fmt --check, cargo clippy --locked --all-targets -- -D warnings and cargo machete --with-metadata passed. Its cargo test did not finish: #75's login_on_a_terminal_reports_why_no_profile_was_saved_and_still_succeeds hung for 28 minutes, and I stopped it. This PR does not touch that test. CI is green.
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A list that returns every item in one response, such as
wallets list, now accepts--alland ignores it. Before, it rejected--all, and clap suggested--wallet:$ voltage wallets list --all # before: error: unexpected argument '--all' found ... tip: a similar argument exists: '--wallet'--all--limit(payments list,quotes list, …)wallets list,webhooks list,assets list,credit-lines list)wallets get, …)An agent that asks for "all" gets what it asked for, without a failed call.
wallets list --helpstill lists--all-orgsfor other organizations.In the CLI benchmark, this happened in 2 of the 6 CLI runs of "list every wallet". Closes #82.
Stack: 5 of 6, on #93. It doesn't depend on the PRs below it.
CHANGELOG.md(Unreleased) line is added. The flag's help text documents it; no guide lists--allfor these commands.cargo test(260 tests) andcheck-coverage.py.Operation::lists_everything_at_onceis true forwallets listandwebhooks list, and false for a paginated list, a read and a create.wallets list --allandwebhooks list --allparse withall = false,payments list --allstill pages, andwallets get --allis still rejected.2ae32e0: 0 functions at or above 20. The highest iswait_for_paymentat 19.60. The list flags moved intolist_args(3.0), soendpointdrops from 18.0 to 17.0;lists_everything_at_onceis 4.0.