fix: validate patch indices read from a file instead of panicking - #9741
Open
jackylee-ch wants to merge 1 commit into
Open
fix: validate patch indices read from a file instead of panicking#9741jackylee-ch wants to merge 1 commit into
jackylee-ch wants to merge 1 commit into
Conversation
Two fuzzer files reach a write loop through unvalidated patch indices: fuzz3.vortex panics in BitBufferMut::set via BoolArray::patch, fuzz3b.vortex in patch_chunk's bare index. Patches::new does bound the maximum, but it derives it from indices[len - 1], which is only the maximum when the indices are sorted, and sortedness is asserted under debug_assertions only. Unsorted indices deserialized from a file therefore pass construction and reach code that indexes without checking. Each site that writes through patch indices now scans the slice up front, or checks the subtraction it previously did blind. This is contained at the use sites because patches_from_slots and its nine call sites are covered by five open PRs, and one of them is replacing Patches outright. Signed-off-by: jackylee <qcsd2011@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fuzzer files reach a write loop through unvalidated patch indices:
fuzz3.vortexpanics inBitBufferMut::set("index 402653634 exceeds len 1024"),fuzz3b.vortexinpatch_chunk's bareindex.
Patches::newdoes bound the maximum, but derives it fromindices[len - 1]— only themaximum when the indices are sorted, and sortedness is asserted under
debug_assertionsonly.Each write site now scans the slice first, or checks the subtraction it was doing blind. Contained at
the use sites on purpose: the check belongs on
Patches, butpatches_from_slotsand its nine callsites are covered by five open PRs, and #9611 is replacing the type outright.
Sparsecanonicalization panics on an out-of-bounds patch index (BitBufferMut::set) #8821Tests
cargo test -p vortex-array -p vortex-alpgoes 3435 → 3442; the two failures in both runs arepre-existing (
arrays::listview::tests::basic::*). Neutralising the two new guards fails 4 of the 5new negative tests; a second mutation covers the fifth.
AI assistance
Written with agentic AI assistance; I traced both backtraces to their write loops and checked the
mutations fail.