Skip to content

fix(buffer): address allocator review follow-ups - #9745

Open
gatesn wants to merge 4 commits into
developfrom
ngates/buffer-review-followups
Open

fix(buffer): address allocator review follow-ups#9745
gatesn wants to merge 4 commits into
developfrom
ngates/buffer-review-followups

refactor(buffer): restrict bytes conversion to byte buffers

8861f3e
Select commit
Loading
Failed to load commit list.
CodSpeed HQ / CodSpeed Performance Analysis failed Sep 3, 2026 in 0s

Performance Regression: -15.34%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 8 improved benchmarks
❌ 38 regressed benchmarks
✅ 2123 untouched benchmarks
🆕 12 new benchmarks
⏩ 218 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation allocate_freeze_drop_vortex_minimal_alignment[64] 3.5 µs 5.6 µs -37.77%
❌ Simulation take_fsl_f16_force_per_index[2048, 10] 361.1 µs 545.3 µs -33.78%
❌ Simulation chunked_varbinview_canonical_into[(1000, 10)] 365.5 µs 551 µs -33.66%
❌ Simulation allocate_drop_vortex[0] 957.4 ns 1,428 ns -32.95%
❌ Simulation chunked_varbinview_into_canonical[(1000, 10)] 405.1 µs 593.3 µs -31.72%
❌ Simulation take_fsl_f16_force_per_index[1024, 10] 209.4 µs 301.3 µs -30.52%
❌ Simulation chunked_varbinview_opt_into_canonical[(1000, 10)] 442.7 µs 625.3 µs -29.2%
❌ Simulation chunked_varbinview_opt_canonical_into[(1000, 10)] 426.4 µs 594.7 µs -28.31%
❌ Simulation take_fsl_f16_force_per_index[512, 10] 133.5 µs 179.7 µs -25.73%
❌ Simulation allocate_drop_vortex_minimal_alignment[0] 901.5 ns 1,206.1 ns -25.25%
❌ Simulation chunked_varbinview_canonical_into[(100, 50)] 272.6 µs 362.5 µs -24.81%
❌ Simulation chunked_varbinview_into_canonical[(100, 50)] 347.2 µs 438.2 µs -20.77%
❌ Simulation runend_compress_u32 389.2 µs 487.6 µs -20.18%
❌ Simulation chunked_varbinview_opt_canonical_into[(100, 50)] 362.5 µs 451.1 µs -19.64%
❌ Simulation take_fsl_f16_force_per_index[256, 10] 94.5 µs 117.6 µs -19.64%
❌ Simulation compress[(10000, 4)] 486.2 µs 604.9 µs -19.62%
❌ Simulation non_nullable[32] 252.7 µs 313.1 µs -19.3%
❌ Simulation non_nullable[256] 246.3 µs 305 µs -19.27%
❌ Simulation nullable[256] 247.7 µs 306.6 µs -19.21%
❌ Simulation nullable[32] 254.3 µs 314.7 µs -19.21%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

Comparing ngates/buffer-review-followups (8861f3e) with develop (dab1684)

Open in CodSpeed

Footnotes

  1. 218 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

View more details on CodSpeed HQ