fix: review findings — honest labels, release guards, hermetic action - #4
Merged
Conversation
Review sweep (8-finder pass plus targeted checks) before 1.0.2: - A report with no measurements said `measured`; it now says `unmeasured` (schema value added, pinned by test) — the exact mislabeling the project's own rules forbid. - The release workflow refuses to publish when the pushed tag disagrees with Cargo.toml, reads the version deterministically instead of packages[0], and warns loudly on manual dispatch. GitHub's `*` matches any characters, so the trigger glob alone never was a barrier; now it is defense-in-depth. - Every action step pins RUSTUP_TOOLCHAIN: a rust-toolchain.toml in the consumer's checkout could hijack the launchbound install (and previously the gate). The toolchain contract — your kernel is analyzed under the action's toolchain, inherently — is documented on the input and in the action README, whose example now uses the floating @v1. A truncated or empty gate record surfaces the prune failure instead of a Python traceback. - Lockstep pins are written once per workflow (env), the pin-watch issue names every site a bump must touch, and CONTRIBUTING gains the release checklist including the easy-to-forget floating-v1 move. - rustdoc warnings fixed; orphaned internal section references in docs/research-baseline.md reworded for public readers. Version 1.0.2. Signed-off-by: Vyncint Ng <vyncint@icloud.com>
vyncint
force-pushed
the
fix/review-1.0.2
branch
from
August 20, 2026 12:17
e101c34 to
8e4415f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review sweep (8-finder pass plus targeted checks) before 1.0.2:
measured; it now saysunmeasured(schema value added, pinned by test) — the exact mislabeling the
project's own rules forbid.
with Cargo.toml, reads the version deterministically instead of
packages[0], and warns loudly on manual dispatch. GitHub's
*matchesany characters, so the trigger glob alone never was a barrier; now it is
defense-in-depth.
consumer's checkout could hijack the launchbound install (and previously
the gate). The toolchain contract — your kernel is analyzed under the
action's toolchain, inherently — is documented on the input and in the
action README, whose example now uses the floating @v1. A truncated or
empty gate record surfaces the prune failure instead of a Python
traceback.
names every site a bump must touch, and CONTRIBUTING gains the release
checklist including the easy-to-forget floating-v1 move.
docs/research-baseline.md reworded for public readers. Version 1.0.2.
Signed-off-by: Vyncint Ng vyncint@icloud.com