Repository navigation
Update vulnerable dependencies after repository transfer - #8
Merged
Merged
Conversation
There was a problem hiding this comment.
Confidence Score: 4/5
Summary
Refreshes vulnerable development dependencies and moves CI to Node 22. Runtime dependencies and emitted library files are unchanged, limiting risk to development tooling.
Important Files Changed
| File | Overview |
|---|---|
| .github/workflows/check.yml | Runs TypeScript and export-drift checks on Node 22 |
| package-lock.json | Refreshes development dependencies, replacing Rollup with Rolldown |
| package.json | Upgrades Vitest and Vite without declaring their separate development Node requirement |
| "typescript": "^5.6.0", | ||
| "vitest": "^2.1.0" | ||
| "vite": "^8.3.0", | ||
| "vitest": "^5.0.0" |
There was a problem hiding this comment.
Node 20 contributors now hit engine errors with strict installs; document Vitest’s supported development Node versions separately in contributor instructions or devEngines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-transfer security scanning found vulnerable dependencies in the existing lockfile. Updates the affected dependency graph to patched versions.
Moves the test runner to Vitest 5; development checks require Node >=22.12. Updates CI to Node22.
Validation: npm audit reports zero vulnerabilities; build passes. Full TypeScript test suite passes.
Note
Medium Risk
Major Vitest/Vite dev-dependency jump and CI Node version change can break local or CI test runs; published runtime Node requirement is unchanged.
Overview
Upgrades the TypeScript dev/test stack to Vitest 5 and adds an explicit Vite 8 dev dependency (with a refreshed
package-lock.jsontransitive graph, including the Vite 8 / Rolldown toolchain Vitest 5 expects).@types/nodeis bumped to match.CI alignment: both TypeScript jobs in
.github/workflows/check.ymlnow use Node 22 instead of 20 fornpm ci, lint, test, and export drift checks.Docs: README’s “Running tests locally” section now states that dev checks run on Vitest 5 and need Node 22.12+ (or 24/26), while
engines.nodeinpackage.jsonstays>=20.10.0for package runtime.Reviewed by Cursor Bugbot for commit b9b1eb5. Bugbot is set up for automated code reviews on this repo. Configure here.