Skip to content

Update vulnerable dependencies after repository transfer - #8

Merged
jmcentire merged 2 commits into
mainfrom
maintenance/dependency-security
Sep 13, 2026
Merged

jmcentire merged 2 commits into
mainfrom
maintenance/dependency-security

Conversation

@jmcentire

@jmcentire jmcentire commented Sep 13, 2026 •

Copy link
Copy Markdown
Collaborator

Post-transfer security scanning found vulnerable dependencies in the existing lockfile. Updates the affected dependency graph to patched versions.

Moves the test runner to Vitest 5; development checks require Node >=22.12. Updates CI to Node22.

Validation: npm audit reports zero vulnerabilities; build passes. Full TypeScript test suite passes.


Note

Medium Risk
Major Vitest/Vite dev-dependency jump and CI Node version change can break local or CI test runs; published runtime Node requirement is unchanged.

Overview
Upgrades the TypeScript dev/test stack to Vitest 5 and adds an explicit Vite 8 dev dependency (with a refreshed package-lock.json transitive graph, including the Vite 8 / Rolldown toolchain Vitest 5 expects). @types/node is bumped to match.

CI alignment: both TypeScript jobs in .github/workflows/check.yml now use Node 22 instead of 20 for npm ci, lint, test, and export drift checks.

Docs: README’s “Running tests locally” section now states that dev checks run on Vitest 5 and need Node 22.12+ (or 24/26), while engines.node in package.json stays >=20.10.0 for package runtime.

Reviewed by Cursor Bugbot for commit b9b1eb5. Bugbot is set up for automated code reviews on this repo. Configure here.

@adaptcom adaptcom Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confidence Score: 4/5

Summary

Refreshes vulnerable development dependencies and moves CI to Node 22. Runtime dependencies and emitted library files are unchanged, limiting risk to development tooling.

Important Files Changed

File Overview
.github/workflows/check.yml Runs TypeScript and export-drift checks on Node 22
package-lock.json Refreshes development dependencies, replacing Rollup with Rolldown
package.json Upgrades Vitest and Vite without declaring their separate development Node requirement

↻ Re-run review · View in Adapt

Comment thread package.json
"typescript": "^5.6.0",
"vitest": "^2.1.0"
"vite": "^8.3.0",
"vitest": "^5.0.0"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node 20 contributors now hit engine errors with strict installs; document Vitest’s supported development Node versions separately in contributor instructions or devEngines.

@jmcentire
jmcentire merged commit 853b4ce into main Sep 13, 2026
4 checks passed
@jmc-wander
jmc-wander deleted the maintenance/dependency-security branch September 13, 2026 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant