Repository navigation
test: isolate Codex wake fixture from host session - #90
Merged
Merged
Conversation
There was a problem hiding this comment.
Confidence Score: 5/5
Summary
Test-only fix: clears all three Codex host-session variables the wake resolver reads so --session last resolves from the fixture, not the host. Verified base fails and head passes with host vars set; no production code touched.
Important Files Changed
| File | Overview |
|---|---|
| tests/test_reminders.py | Clear CODEX_SESSION_ID and CODEX_CONVERSATION_ID alongside CODEX_THREAD_ID in subprocess env |
Reviewed d82d2b1...aab0426 · ↻ Re-run review · View in Adapt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the Codex wake reminder CLI test independent of the Codex session running the test suite. The subprocess inherits the parent environment, so clearing only
CODEX_THREAD_IDleftCODEX_SESSION_IDorCODEX_CONVERSATION_IDavailable to the wake resolver. Clear all three session variables so--session lastresolves from the fixture's newest rollout.Verification
newest-thread.3906 passed, 4 skipped, 9 subtests passedwith Python 3.13.15,.[dev,mcp], and four pytest workers.This is a test fixture correction; the reminder resolver's behavior is unchanged.
Need help on this PR? Tag
@codesmith-botwith what you need.