Skip to content

test: isolate Codex wake fixture from host session - #90

Merged
blast-hardcheese merged 2 commits into
mainfrom
fix/codex-wake-test-environment
Oct 20, 2026
Merged

blast-hardcheese merged 2 commits into
mainfrom
fix/codex-wake-test-environment

Conversation

@blast-hardcheese

@blast-hardcheese blast-hardcheese commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Make the Codex wake reminder CLI test independent of the Codex session running the test suite. The subprocess inherits the parent environment, so clearing only CODEX_THREAD_ID left CODEX_SESSION_ID or CODEX_CONVERSATION_ID available to the wake resolver. Clear all three session variables so --session last resolves from the fixture's newest rollout.

Verification

  • Before the change, the focused test failed inside Codex: it selected the host session instead of newest-thread.
  • After the change, the focused test passed with all three host session variables deliberately set.
  • Full suite: 3906 passed, 4 skipped, 9 subtests passed with Python 3.13.15, .[dev,mcp], and four pytest workers.

This is a test fixture correction; the reminder resolver's behavior is unchanged.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@adaptcom adaptcom Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confidence Score: 5/5

Summary

Test-only fix: clears all three Codex host-session variables the wake resolver reads so --session last resolves from the fixture, not the host. Verified base fails and head passes with host vars set; no production code touched.

Important Files Changed

File Overview
tests/test_reminders.py Clear CODEX_SESSION_ID and CODEX_CONVERSATION_ID alongside CODEX_THREAD_ID in subprocess env

Reviewed d82d2b1...aab0426 · ↻ Re-run review · View in Adapt

Comment thread tests/test_reminders.py Outdated
@blast-hardcheese
blast-hardcheese merged commit 41d0bd3 into main Oct 20, 2026
1 check passed
@blast-hardcheese
blast-hardcheese deleted the fix/codex-wake-test-environment branch October 20, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant