Skip to content

Log original OTLP log-export errors to worker logs - #170

Merged
bnavetta merged 1 commit into
mainfrom
factory/otlp-log-export-errors
Oct 18, 2026
Merged

bnavetta merged 1 commit into
mainfrom
factory/otlp-log-export-errors

Conversation

@warp-agent-staging

Copy link
Copy Markdown
Contributor

Keep the original task log-export error in worker zerolog output so operators can diagnose collector failures. The task-context logger is deliberately bypassed, and OpenTelemetry still receives only task log export failed.

Raw collector errors can contain reflected credentials. These details now appear in operator-controlled worker logs, not task OTLP logs. Trace exporters and initialization/shutdown errors are unchanged.

Validation

  • Added an HTTP collector regression test for local diagnostic visibility, an untouched task-context logger, and a sanitized returned error. It fails before the fix and passes afterward.
  • Passed go test -race ./internal/tasktelemetry/....
  • Passed go vet ./internal/tasktelemetry/..., golangci-lint run ./internal/tasktelemetry/..., and go build ./....
  • Applied gofmt -s to both changed files.

Request

@cla-bot cla-bot Bot added the cla-signed label Oct 18, 2026
@warp-agent-staging

Copy link
Copy Markdown
Contributor Author

This PR was generated with Warp.

Comment @warp-staging-factory on this PR to send it follow-up work.

View run View conversation View on Slack

@warp-agent-staging warp-agent-staging Bot added the factory:eng-factory-slim Label associated to the "eng-factory-slim" factory label Oct 18, 2026
@warp-agent-staging
warp-agent-staging Bot requested a review from bnavetta October 18, 2026 20:15
@warp-agent-staging
warp-agent-staging Bot marked this pull request as ready for review October 18, 2026 20:15
@bnavetta
bnavetta merged commit bc5bd37 into main Oct 18, 2026
8 checks passed
@bnavetta
bnavetta deleted the factory/otlp-log-export-errors branch October 18, 2026 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed factory:eng-factory-slim Label associated to the "eng-factory-slim" factory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant