Skip to content

Fix reserved byte identifiers in the new streaming workload cases #544

Description

@LunaStev

Two cases introduced in #520 use the reserved type token byte as an ordinary identifier: a local in shared/test114.wave:32 and a function parameter in macos/arm64/test6.wave:34. The lexer emits TypeByte, so both fail parsing before their algorithms or OS operations can be exercised.

Linux case CI stops while checking the macOS file; Windows ARM64 case CI separately reports the shared case failure. These are observed remote CI failures, not target-specific language differences.

Source evidence at the head of #520:

Acceptance:

  • Rename only the local/parameter and their references to an ordinary descriptive identifier.
  • Preserve both algorithms, checks and platform placement; do not delete/skip the tests or weaken keyword recognition.
  • Verify both source files parse, then run the shared workload and the native macOS kqueue workload on their supported runners.
  • Keep legitimate byte type uses such as shared/test61.wave intact.

Related: Draft PR #520. #436 concerns the separate computed-index limitation exposed by the LoongArch workload.

Audit status: reproduced by the linked remote PR CI at commit 2ae0a91; no additional local build or execution was run during this audit.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugA problem that causes incorrect behavior or crashes.ciGitHub CI or CIgood first issueIssues that are good for newcomers or first-time contributors.multi-os testingIssues related to testing Wave on multiple operating systems.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions