Repository navigation
Add Waveshare 5.0-DSI-TOUCH-A-V2 / 5.0-DSI-TOUCH-B panels and fix DSI1 timing on CM4 - #16
Open
EngineerWill wants to merge 4 commits into
Open
EngineerWill wants to merge 4 commits into
EngineerWill wants to merge 4 commits into
Conversation
On the Compute Module 4, the Waveshare 8-DSI-TOUCH-A panel lights up correctly on DSI0 but fails to light up on DSI1 with the current timing. Update the display timing accordingly so that the panel also works on DSI1: widen the horizontal sync pulse from 20 to 30 pixels and raise the pixel clock from 70 MHz to 71 MHz. The new timing totals 890x1326 pixels, which gives a refresh rate of about 60.2 Hz. Signed-off-by: Yu Dukai <646689853@qq.com>
On the Compute Module 4, the Waveshare 5-DSI-TOUCH-A panel lights up correctly on DSI0 but fails to light up on DSI1 with the current timing. Update the display timing accordingly so that the panel also works on DSI1: widen the horizontal sync pulse from 20 to 30 pixels. The resulting 810x1324 pixel timing already reaches the required refresh rate at the existing 70 MHz pixel clock, so the clock is left unchanged. Signed-off-by: Yu Dukai <646689853@qq.com>
Add the display mode and initialization sequence for the Waveshare 5.0-DSI-TOUCH-A-V2 and 5.0-DSI-TOUCH-B panels. The two products use the same 720x1280 display panel and differ only in the touch cover glass, so they share a single panel description: two MIPI DSI lanes, a 70 MHz pixel clock and the minimal sleep-out/display-on sequence. Signed-off-by: Yu Dukai <646689853@qq.com>
Add overlay options for the Waveshare 5.0-DSI-TOUCH-A-V2 and 5.0-DSI-TOUCH-B panels. The 5_0_inch_a_v2 and 5_0_inch_b options select the two-lane 720x1280 panel. The two products use the same display panel and differ only in the touch cover glass, so both options point at the same panel description. Signed-off-by: Yu Dukai <646689853@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This series adds support for two new Waveshare DSI panels and fixes the
display timing of the existing 5.0" and 8.0" DSI-TOUCH-A panels so that
they also work when driven from DSI1.
New panels
Waveshare 5.0-DSI-TOUCH-A-V2 and 5.0-DSI-TOUCH-B are 720x1280 panels
driven over two MIPI DSI lanes at a 70 MHz pixel clock, RGB888. Both
products use the same display panel and differ only in the touch cover
glass, so they share a single panel description, exposed through the new
compatibles "waveshare,5.0-dsi-touch-a-v2" and "waveshare,5.0-dsi-touch-b".
The panels need no vendor initialization, only the generic sleep-out and
display-on sequence, so the init table is minimal.
The overlay gains the matching 5_0_inch_a_v2 and 5_0_inch_b parameters,
and the overlays README is updated.
Timing fixes
On a Compute Module 4 the Waveshare 5.0-DSI-TOUCH-A and 8.0-DSI-TOUCH-A
panels light up correctly on DSI0 but do not light up on DSI1 with the
current timing.
Widen the horizontal sync pulse from 20 to 30 pixels for both panels and
additionally raise the 8.0" pixel clock from 70 MHz to 71 MHz. The 5.0"
timing already reaches the required refresh rate with the existing 70 MHz
clock, so that clock is left unchanged. This follows the same approach as
the earlier 10.1-DSI-TOUCH-A fix.
Testing
Tested on with vc4-kms-v3d and:
dtoverlay=vc4-kms-dsi-waveshare-panel-v2,5_0_inch_a_v2
dtoverlay=vc4-kms-dsi-waveshare-panel-v2,5_0_inch_b
dtoverlay=vc4-kms-dsi-waveshare-panel-v2,5_0_inch_a
dtoverlay=vc4-kms-dsi-waveshare-panel-v2,8_0_inch_a