chore: preserve the unmerged provider-retry fix in the Letta archive - #24
Merged
Merged
Conversation
PR #18 was closed as superseded, and its closing comment said the reasoning would be carried forward in this directory's README. It was not: the archive documented the runtime and left the retry out entirely, so the branch was the only copy of the work and the last non-main ref on the remote. Keep the artifact, drop it from the live tree. The module still has no caller now that Data answers through /zo/ask, so it moves to `archives/letta-brain/lib/` with the archived service that wired it, and the archive README records what it did, why it was never deployed, and what makes it worth keeping: read the delay the provider named, and bound it. The archive now typechecks and its test runs (`archives/**/*.ts` in tsconfig, `archives/*/lib/*.test.ts` in the test glob), so what is kept here is verified rather than inert.
|
This pull request archives the
Reviewers should start by examining |
1 similar comment
|
This pull request archives the
Reviewers should start by examining |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files the keep-or-drop judgment on
fix/provider-rate-limit-retry, the last non-main branch on the remote.Why it needs a PR and not a cleanup
PR #18 was closed on 2026-09-26T07:00:08Z as superseded by #22, and its closing comment promised the reasoning would be carried forward in the archive's README. It was not.
archives/letta-brain/README.mddocuments the runtime and never mentions the retry, so the branch remained the only copy of the work — and the only ref on the remote besidesmain.The judgment
Drop it from the live tree, keep it as a record. The module's only importer was
channels/http/, and Data answers through/zo/asknow, so provider capacity is Zo's concern rather than this repository's. A module nothing imports does not belong inlib/— the same test that retired the.afprojection and this whole runtime in #22.The reusable part is the rule rather than the service: honour the delay the provider named, bound it, and retry only a failure the provider explicitly flagged as retryable (a missing conversation, an unconfigured provider, and a timeout are all left alone). That is worth more than the service it was written for, which is why it is here instead of on a branch.
What lands
archives/letta-brain/lib/provider-retry.tsand its test, byte-identical to the branch.channels/http/andservices/copies, carrying the wiring, so the fix reads in context. These are now the runtime as it would have been rather than as it stood; the README says so.tsconfig.jsonincludesarchives/**/*.tsandnpm testcoversarchives/*/lib/*.test.ts, so the archived code is typechecked and its test verified in CI rather than sitting inert.Verified
npm run typecheckclean andnpm test38/38 one5916be, run locally inworktrees/data/archive-provider-retry. The five ported files are byte-identical to4db2c21.After this merges
fix/provider-rate-limit-retry(4db2c21) is prunable: its content is then inmain, and its PR is closed. That is a remote-branch deletion, so it wants your go-ahead.Closes nothing; supersedes the closed #18.