fix(ci): skip Mattermost notifications for external pull requests - #1281
Merged
Merged
Conversation
addshore
approved these changes
Sep 28, 2026
Collaborator
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI job that sends a Mattermost message when a PR is (re-)opened, defined in
.github/workflows/mattermost.yml, fails withError: Input required and not supplied: MATTERMOST_WEBHOOK_URLfor PRs from external repositories.Contributors have expressed a desire for CI workflows to not fail for reasons outside of their control (1 2).
This would involve either:
The later is the safer option and doesn't risk diverting the team's attention away from the focus topic, so I'm inclined to go that route to start with.