Conversation
Accept PNG and SVG logos up to 2 MiB. Sanitise SVGs before storage, check embedded CSS using Wikimedia's CSS parser, and generate PNG logo and favicon fallbacks with rsvg-convert (as svg support is less than png support). Basically all based on mediawikis own handling. Store the vector URL in wwLogoSvg and clear it when a PNG replaces the logo. Add regression coverage and document the processing requirements. The MW change wbstack/mediawiki#569 would be needed ahead of this. Bug: T356389
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept PNG and SVG logos up to 2 MiB. Sanitise SVGs before storage, check embedded CSS using Wikimedia's CSS parser, and generate PNG logo and favicon fallbacks with rsvg-convert (as svg support is less than png support).
Basically all based on mediawikis own handling.
Store the vector URL in wwLogoSvg and clear it when a PNG replaces the logo. Add regression coverage and document the processing requirements.
The MW change wbstack/mediawiki#569 would be needed ahead of this.
Bug: T356389