Skip to content

Remove duplicate Elasticsearch host from API queue deployments - #220

Open
addshore wants to merge 1 commit into
mainfrom
fix/api-queue-elasticsearch-env
Open

addshore wants to merge 1 commit into
mainfrom
fix/api-queue-elasticsearch-env

Conversation

@addshore

Copy link
Copy Markdown
Collaborator

deployment-queue.yaml already includes api.commonAppEnvVars defined in charts/api/templates/_helpers.tpl.
That helper emits ELASTICSEARCH_HOST when app.elasticSearchHost is configured, so the additional inline entry rendered the same environment variable twice.

During local-dev testing, changing the Elasticsearch hostname through a Helm upgrade left one duplicate entry with the previous hostname. Kubernetes strategic merge patches identify environment entries by name, so duplicate names make updates ambiguous and can leave stale values in the pod specification.

Remove the inline entry and retain the shared helper as the single source of ELASTICSEARCH_HOST. When the host is configured, the rendered queue deployment now contains exactly one entry with the configured value.

deployment-queue.yaml already includes api.commonAppEnvVars
defined in charts/api/templates/_helpers.tpl.
That helper emits ELASTICSEARCH_HOST when app.elasticSearchHost is configured,
so the additional inline entry rendered the same environment variable twice.

During local-dev testing, changing the Elasticsearch hostname through a Helm upgrade
left one duplicate entry with the previous hostname.
Kubernetes strategic merge patches identify environment entries by name,
so duplicate names make updates ambiguous and can leave stale values in the pod specification.

Remove the inline entry and retain the shared helper as the single source of ELASTICSEARCH_HOST.
When the host is configured, the rendered queue deployment now contains exactly one entry with the configured value.

**API chart `0.36.0` introduced the duplicate**, in commit `89fbef2`
@addshore
addshore force-pushed the fix/api-queue-elasticsearch-env branch from d7ee613 to 8ce03a2 Compare September 27, 2026 22:52

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant