Conversation
Load Modern only when the wiki default is modern. Keep the skin packaged for those wikis and update both authoritative and generated LocalSettings files. Bug: T418562
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Load Modern only when the wiki default is modern. Keep the skin packaged for those wikis and update both authoritative and generated LocalSettings files.
This makes the assumption that users have not specifically selected modern as a user preference,
and that if they have we don't worry about it (see my comment in the ticket).
Looking at how mediawiki would handle this...
For a user whose personal preference is
skin=modernon a wiki whose default is Vector,MediaWiki renders Vector. It should not throw an error or show the fallback warning.
Bug: T418562