Add a buffer_view variant option to wireframe sample - #568
Merged
Conversation
alan-baker
commented
Jun 23, 2026
alan-baker
commented
Contributor
- Combines all model data into a single buffer
- Beginning of the buffer has model metadata
- vertex and index buffers for each draw set from offsets into the buffer
- buffer_view shaders passed the whole buffer
* Combines all model data into a single buffer
* Beginning of the buffer has model metadata
* vertex and index buffers for each draw set from offsets into the
buffer
* buffer_view shaders passed the whole buffer
Contributor
Author
|
@beaufortfrancois thoughts on this as the buffer_view example we discussed? |
beaufortfrancois
left a comment
beaufortfrancois
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for starting this!
mwyrzykowski
approved these changes
Jun 23, 2026
beaufortfrancois
approved these changes
Jun 23, 2026
alan-baker
marked this pull request as ready for review
June 23, 2026 16:44
beaufortfrancois
approved these changes
Aug 5, 2026
beaufortfrancois
enabled auto-merge (squash)
August 5, 2026 04:17
|
Any browser to test? |
Contributor
Author
It works in Chrome Canary (153). Full chrome release is slated for September 8, 2026. |
|
Ok thanks.. also on Android canary? Can’t see reported on webgpu report
site even on chrome canary for android updated today at 154.0.8015..
So two questions
1) has webgpureport.org support for reporting this feature or web page has
to be updated too?
2) how to know if sample is using it without using chrome developer tools?
El El vie, 21 ago 2026 a las 19:51, alan-baker ***@***.***>
escribió:
… *alan-baker* left a comment (webgpu/webgpu-samples#568)
<#568 (comment)>
Any browser to test?
It works in Chrome Canary (153). Full chrome release is slated for
September 8, 2026.
—
Reply to this email directly, view it on GitHub
<#568?email_source=notifications&email_token=AAFDM6JLTKZWMQXFDXTVQXD5LCD2TA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMZXGMZTKMZXG42KM4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5373353774>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFDM6J7QR3YTRJAGOFI5H35LCD2TAVCNFSNUABFKJSXA33TNF2G64TZHMYTONZWGQ2TEMRXHNEXG43VMU5TINZSGE4TONZVHEY2C5QC>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Contributor
Author
It should be, I've tested it on a Pixel 10. The sample will not display the checkbox for bufferView in the options if the feature is not available. There should be no visual difference when enabled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.