Skip to content

fix: update libdatachannel to 0.24.6 #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mertushka merged 2 commits into from
Oct 11, 2026
Merged

fix: update libdatachannel to 0.24.6 #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27ab1b3
fix: update libdatachannel to 0.24.6
mertushka Oct 11, 2026
9700602
Merge branch 'main' into fix/libdatachannel-0.24.6
mertushka Oct 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ execute_process(
string(REPLACE "\"" "" NODE_ADDON_API_DIR "${NODE_ADDON_API_DIR}")
string(REPLACE "\\" "/" NODE_ADDON_API_DIR "${NODE_ADDON_API_DIR}")

set(LIBDATACHANNEL_PINNED_COMMIT "188ec93f6a0b01c2032ddb4c8c013118f7f30232" CACHE STRING
set(LIBDATACHANNEL_PINNED_COMMIT "6b1e2e620f1e37f0eafeee702eaea0043cb305fd" CACHE STRING
"Audited libdatachannel commit for this binding.")

set(LIBDATACHANNEL_REPOSITORY "https://github.com/paullouisageneau/libdatachannel.git" CACHE STRING
Expand Down
5 changes: 5 additions & 0 deletions docs/development.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ npm run build
thread-safe callback dispatch. The build uses `cmake-js` and links
`LibDataChannel::LibDataChannelStatic`.

The audited native dependency is libdatachannel v0.24.6, pinned to
`6b1e2e620f1e37f0eafeee702eaea0043cb305fd`. It includes fixes for DTLS startup
ordering, TURN handshake deadlocks, and ICE option separators. The CMake pin
and `wpt-manifest.json` dependency metadata must stay in sync.

If a local `libdatachannel/` checkout exists, CMake verifies it against the
pinned commit. Otherwise it fetches the pinned upstream commit with
`FetchContent`.
Expand Down
2 changes: 1 addition & 1 deletion wpt-manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"libdatachannelRepository": "https://github.com/paullouisageneau/libdatachannel.git",
"libdatachannelCommit": "188ec93f6a0b01c2032ddb4c8c013118f7f30232",
"libdatachannelCommit": "6b1e2e620f1e37f0eafeee702eaea0043cb305fd",
"wptCommit": "03169f171c797d0953b21d7388561b454fde0ad4",
"expectedSelectedSubtests": 620,
"selectedSubtestsSha256": "967896888c9496738e4911ec1eff073a1d0fff701352729c3de2e51665e8bb97",
Expand Down
Loading