sysinfo.pl 1.2.3: fix memory used/free swapped in display and percent - #611
Merged
Merged
Conversation
memoryusage() computed $vard as actual used memory (Total - Free - Buffers - Cached), but the final return statement treated it as if it were free memory: it displayed human_size($vara-$vard) as "used" and computed the percentage as 100-($vard/($vara-$vard)*100). This mislabeled free memory as used in the output, and produced a negative percentage whenever used memory exceeded free memory (e.g. '2.83GB/7.57GB (-67.52%)' on a host where 4.74GB was actually in use). Fix by using $vard directly as used memory in both the display and the percentage calculation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
memoryusage()computes$vardas the actual used memory (Total - Free - Buffers - Cached), but the final return statement treats it as if it were free memory instead:This mislabels free memory as used in the displayed output, and can produce a negative percentage whenever used memory exceeds free memory, e.g.:
(on a host where 4.74GB was actually in use, i.e. ~62.6%).
Fix by using $vard directly for both the display and the percentage:
This follows up #610 (merged as 1.2.2), which fixed the kernel-version detection but left this separate used/free swap in place.