Repository navigation
fix: name the gateway release and image asobi_dgram - #517
Merged
Merged
Conversation
Three names for one artifact, which is two too many: the OTP application is `asobi_dgram_gw`, the release was `asobi_gw` and the image was `asobi-dgram`. The hyphen is also wrong twice over - Erlang names use underscores, and the org's published images use them too. The release and the image are now both `asobi_dgram`, so a self-hoster reads one name in the compose file, the Dockerfile and the release directory. The OTP application keeps `_gw`. Inside it, `asobi_dgram` is already the codec module that both roles share, and the application is specifically the gateway half - so the suffix is carrying meaning there rather than noise. `ghcr.io/widgrensit/asobi-dgram` was published once, from the #514 merge. It is orphaned now and worth deleting: an image nobody should pull is worse sitting in the registry than absent from it.
🟡 Code Coverage — 76.2%8597 of 11280 lines covered. 🟡 ELP Lint — 192 warnings210 diagnostics found. See job logs for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three names for one artifact, which is two too many:
asobi_dgram_gwasobi_dgram_gwasobi_gwasobi_dgramasobi-dgramasobi_dgramThe hyphen was wrong twice over: Erlang names use underscores, and the org's published images do too.
The release and the image are now both
asobi_dgram, so a self-hoster reads one name in the compose file, the Dockerfile,bin/asobi_dgramand the release directory.The OTP application keeps
_gw, deliberately. Inside it,asobi_dgramis already the codec module that both roles share, and the application is specifically the gateway half — so the suffix carries meaning there rather than noise. If you'd rather have strict 1:1 across all three, say so and I'll rename the app too; it's contained (the app.src, three module names, the closure guard and one test).Verified after the rename: the release assembles, its closure is still exactly
asobi_dgram_gw crypto kernel sasl seki stdlib telemetry,bin/asobi_dgramis present, and the application boots standalone. Both workflow files still parse.One cleanup outside this PR
ghcr.io/widgrensit/asobi-dgramwas published once, by the #514 merge, before this rename. It is orphaned now and worth deleting from the registry — an image nobody should pull is worse sitting there than absent. That needs package-admin rights I don't have from here.