Repository navigation
fix(x86_64): relax only full 64-bit read for R_X86_64_GOTPCREL - #2732
Merged
Merged
Conversation
marxin
commented
Oct 15, 2026
marxin
force-pushed
the
fix-partial-got-address-read
branch
from
October 15, 2026 08:05
d383154 to
cc80029
Compare
marxin
force-pushed
the
fix-partial-got-address-read
branch
from
October 16, 2026 05:52
2e77fb3 to
4d78ad7
Compare
davidlattimore
left a comment
davidlattimore
left a comment
Member
There was a problem hiding this comment.
Looks like you added the test but missed the change to make it pass?
Collaborator
Author
|
Yes, will pass now. |
davidlattimore
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.