Repository navigation
fix: Windows compatibility and validated v0.4.22 packaging - #69
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows builds failed on drive-letter paths, backslashes, POSIX-only process launching, Python scripts inside app.asar, and Chinese Python output. Narrow windows also allowed analysis controls to overlap the teacher pane.
This change fixes those paths/processes, extracts review scripts before Python execution, forces UTF-8 for offline speech, makes the board header responsive, and accepts the system OpenCL driver dependency. It prepares v0.4.22 and gates publication on tests, typechecks, teaching quality, release policy/version checks, and real NSIS installation/file-integrity/uninstallation checks for both Windows editions.
Validated on Windows 11 with RTX 5090 and AMD Radeon:
The local workspace installation initially omitted DLLs; the identical artifacts installed completely in system temporary directories. Compression changes did not fix that workspace-only behavior and were not retained. The new installer gate checks every installed file instead of relying only on an exit code or app startup.