Repository navigation
fix: macOS signing keychain password for v0.4.22 - #70
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.4.22 packaging run failed because electron-builder 26.8.1 passes a certificate import password to macOS
security set-key-partition-list, which requires the generated temporary keychain password.Backport upstream electron-builder PR #10101 (electron-userland/electron-builder#10101) through pnpm's hash-locked patch for app-builder-lib 26.8.1. Certificate import passwords remain separate; signing failures still propagate, and all signing/notarization checks remain enabled. No dependency upgrades or application runtime changes.
Validation: 336 tests total, 332 passed, 4 platform skips, 0 failures; frozen lockfile installation passed. Five tests exercise the installed patched signing module, including separate application/installer certificate passwords and failure propagation. Restoring the old password behavior makes all three signing success cases fail. Multilingual release notes checks pass.
Actual macOS signing/notarization will be verified by the complete release workflow before publication.