Skip to content

feat: add opt-in discovery of Codex on PATH - #72

Open
hacbit wants to merge 1 commit into
wimi321:mainfrom
hacbit:feat/optional-system-codex
Open

hacbit wants to merge 1 commit into
wimi321:mainfrom
hacbit:feat/optional-system-codex

Conversation

@hacbit

@hacbit hacbit commented Oct 24, 2026

Copy link
Copy Markdown

Summary

Add an opt-in “Prefer Codex on PATH” setting for ChatGPT connections.

  • Keep the existing runtime discovery behavior by default.
  • When enabled, search PATH before falling back to the bundled runtime.
  • Preserve precedence for explicit paths and GOAGENT_CODEX_BIN.
  • Resolve Windows npm shims to the native executable without invoking a shell.
  • Recreate the runtime and reset verification when the setting changes.
  • Add localized UI text and discovery tests.

Verification

  • pnpm typecheck
  • pnpm build
  • pnpm test: 336 passed, 5 skipped, 0 failed
  • Windows desktop: enabled the option and confirmed connection verification passed

Notes

Existing configurations leave this option disabled.

Fixes #71

Keep bundled runtime discovery as the default. Add a persisted ChatGPT
connection option to prefer a system Codex installation while retaining
explicit path overrides and bundled fallback. Resolve Windows npm shims
to their native executable without invoking a command shell.

Recreate the runtime and invalidate verification when the option changes.
Add localized settings copy and tests for discovery order and fallback.

Validation:
- pnpm typecheck
- pnpm build
- pnpm test: 336 passed, 5 skipped, 0 failed
- User verified the enabled option in the Windows desktop test build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: 支持本地环境的 codex 命令

1 participant