Repository navigation
Resolve relative paths to absolute before Windows path conversion - #968
Open
miles-read wants to merge 3 commits into
Open
miles-read wants to merge 3 commits into
miles-read wants to merge 3 commits into
Conversation
Member
|
Hi, please sign off on your commits (see the DCO check on how to do that). Also, please indent the if statement and the comment by another 4 spaces. Then, this will be ready to merge. |
for more information, see https://pre-commit.ci Signed-off-by: miles-read <readmiles00@gmail.com>
Signed-off-by: miles-read <readmiles00@gmail.com>
miles-read
force-pushed
the
fix-relative-file-path
branch
from
September 16, 2026 09:54
963c919 to
e8fd503
Compare
Member
|
Your first commit still isn't signed off. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small change to fix opening files using relative paths.
The existing sed substitution only matches paths already prefixed with $HOME or $REMOVABLE_MEDIA, so a relative path falls through unconverted.