Repository navigation
fix: try all neighbour IPs when RDP port check fails - #986
Merged
Merged
Conversation
ip neigh can return multiple addresses for the same VM MAC after a reset; probe each candidate and include the IP in BAD_PORT (#432). Signed-off-by: MrVi <support@b4dcat.ru>
mrvi0
force-pushed
the
fix/432-multi-ip-bad-port
branch
from
October 16, 2026 09:41
2d3f844 to
e40ac0c
Compare
oskardotglobal
approved these changes
Oct 16, 2026
oskardotglobal
left a comment
oskardotglobal
left a comment
Member
There was a problem hiding this comment.
Looks good. Thanks for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ip neighlists multiple IPs for the VM MAC, try each address until RDP answers instead of stuffing newlines intonc//dev/tcpBAD_PORTnotification (on ip '…') for easier debuggingFixes #432