fix: starting conversation with user without clients (WPB-18997) - #5190
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5190 +/- ##
========================================
Coverage 53.02% 53.03%
========================================
Files 745 745
Lines 25831 25834 +3
Branches 4240 4241 +1
========================================
+ Hits 13698 13701 +3
Misses 10794 10794
Partials 1339 1339
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Contributor
Contributor
|
APKs built during tests are available here. Scroll down to Artifacts! |
yamilmedina
approved these changes
Aug 20, 2026
Member
|
Shouldn't we show an alert telling current user, that user X needs to open Wire or log in again first ? |
saleniuk
approved these changes
Sep 3, 2026
sbakhtiarov
enabled auto-merge
September 7, 2026 11:47
sbakhtiarov
force-pushed
the
fix/no-clients-conversation
branch
from
September 7, 2026 14:46
06a5b33 to
aa79855
Compare
Contributor
|
APKs built during tests are available here. Scroll down to Artifacts! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-18997
https://wearezeta.atlassian.net/browse/WPB-18997
What's new in this PR?
Issues
Android client allows creating 1:1 conversation with the user without clients (e.g. never logged in wire app).
Solutions
Using new use case introduced in wireapp/kalium#4404 to resolve one-on-one conversations correctly.