feat: support cancelling backup restore (WPB-19677) - #5245
Open
sbakhtiarov wants to merge 1 commit into
Open
Conversation
saleniuk
approved these changes
Sep 3, 2026
Comment on lines
+143
to
+145
| isRestoreCompleted -> stringResource(R.string.label_ok) | ||
| isCancelling -> stringResource(R.string.backup_label_cancelling) | ||
| canCancel -> stringResource(R.string.label_cancel) |
Contributor
There was a problem hiding this comment.
Maybe we could replace these three booleans with enum representing current state 馃
yamilmedina
approved these changes
Sep 3, 2026
sbakhtiarov
enabled auto-merge
September 4, 2026 13:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-19677
What's new in this PR?
Issues
The Cancel button did not stop an in-progress multiplatform backup restore.
Causes (Optional)
Restore and backup jobs were not separated, and the UI had no cancellation lifecycle that waited for persistence and temporary-file cleanup.
Solutions