Skip to content

feat: handle meeting tzid [WPB-27614] - #5248

Open
saleniuk wants to merge 4 commits into
developfrom
feat/meetings-tzid
Open

feat: handle meeting tzid [WPB-27614]#5248
saleniuk wants to merge 4 commits into
developfrom
feat/meetings-tzid

Conversation

@saleniuk

@saleniuk saleniuk commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-27614


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Handling TZID field for meetings, to calculate recurrences properly.

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Create recurring meeting in a location where the time zone changes during the year (DST time) and check that the meeting occurrence times stay the same even after changing the DST time.

Here is an example - weekly meeting starting at 10AM Berlin time and also shown from the perspective of someone in Sydney, where, in the Southern Hemisphere, time changes throughout the year are the opposite of those in the Northern Hemisphere and also occur on different dates, so there are transitional periods between the time changes in these two locations.
When viewing the calendar in Sydney time, the event should not stay at the fixed time, user should explicitly see the time change from 6:00 PM → 7:00 PM → 8:00 PM across those three distinct seasonal phases.

Occurrence Date Berlin Local Time Berlin Offset Underlying UTC Time Time Gap Sydney Local Time Sydney Offset Alignment Phase
Wed, Sept 30 10:00 AM UTC+2 08:00 AM UTC 8 hours 06:00 PM UTC+10 Initial Setup: Berlin in summer time (CEST) / Sydney in winter time (AEST).
Sun, Oct 4 Sydney springs forward to summer time (AEDT; Clocks +1 hour)
Wed, Oct 7 10:00 AM UTC+2 08:00 AM UTC 9 hours 07:00 PM UTC+11 Intermediate Phase: Both cities simultaneously in summer alignment.
Sun, Oct 25 Berlin falls back to winter time (CET; Clocks -1 hour)
Wed, Oct 28 10:00 AM UTC+1 09:00 AM UTC 10 hours 08:00 PM UTC+11 Final Phase: Berlin in winter time (CET) / Sydney in summer time (AEDT).

Attachments (Optional)

tzid.mov

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.06%. Comparing base (cb21638) to head (661cf8a).

Files with missing lines Patch % Lines
.../feature/meetings/ui/create/NewMeetingViewModel.kt 85.71% 2 Missing and 1 partial ⚠️
.../wire/android/util/time/CurrentTimeZoneProvider.kt 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5248      +/-   ##
===========================================
+ Coverage    53.04%   53.06%   +0.01%     
===========================================
  Files          745      745              
  Lines        25824    25838      +14     
  Branches      4236     4238       +2     
===========================================
+ Hits         13698    13710      +12     
  Misses       10792    10792              
- Partials      1334     1336       +2     
Files with missing lines Coverage Δ
...bserveImageAssetMessagesFromConversationUseCase.kt 84.84% <100.00%> (ø)
.../wire/android/util/time/CurrentTimeZoneProvider.kt 75.00% <75.00%> (ø)
.../feature/meetings/ui/create/NewMeetingViewModel.kt 86.47% <85.71%> (-0.20%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb21638...661cf8a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Test Results

2 673 tests  +5   2 673 ✅ +5   1m 44s ⏱️ -1s
  338 suites ±0       0 💤 ±0 
  338 files   ±0       0 ❌ ±0 

Results for commit 661cf8a. ± Comparison against base commit cb21638.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant