Skip to content

Optimize OutputIterator using a queue structure #3725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Astralcircle merged 3 commits into from
Sep 21, 2026
Merged

Optimize OutputIterator using a queue structure #3725

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a576b3
perf(wirelib): optimize OutputIterator using a queue structure)
n1lordduck Sep 20, 2026
7b9f043
Reset values after ending processing
Astralcircle Sep 21, 2026
48861ac
Reset to 1 instead of 0
Astralcircle Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions lua/wire/server/wirelib.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -898,25 +898,34 @@ do -- class OutputIterator
OutputIterator.__index = OutputIterator

function OutputIterator:Add(ent, iname, value)
table.insert(self, { Entity = ent, IName = iname, Value = value })
local last = self.last + 1

self.last = last
self[last] = { Entity = ent, IName = iname, Value = value }
end

function OutputIterator:Process()
if self.Processing then return end -- should not occur
self.Processing = true

while #self > 0 do
local nextelement = self[1]
table.remove(self, 1)
while self.first <= self.last do
local first = self.first
local nextelement = self[first]

self[first] = nil
self.first = first + 1

WireLib.TriggerInput(nextelement.Entity, nextelement.IName, nextelement.Value, self)
end

self.first = 1
self.last = 0

self.Processing = nil
end

function WireLib.CreateOutputIterator()
return setmetatable({}, OutputIterator)
return setmetatable({ first = 1, last = 0 }, OutputIterator)
end
end -- class OutputIterator

Expand Down
Loading