Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cancel-in-progress: truealso applied to pushes tomain, so a later push could cancel the run on the commit before it and lose that commit's verdict. That verdict is whatPublishwaits for, so a cancelled run also meant no publish for the commit. A push tomainor a manual run now gets a concurrency group of its own, and only a pull request's run is cancelled when a newer one starts.Changes
ci.ymlandopenapi-validate.yml: the concurrency group is the pull request's ref for a pull request and the run id for anything else.cancel-in-progressis true only for a pull request.codeql.yml: the same rule. Its group also includes whether a pull request is a draft, because it skips a draft and analyzes the pull request onready_for_review, so a draft's run and the ready run no longer cancel each other..github/scripts/ci-changes.test.sh: pins the per-run group and the cancellation rule forci.yml.Testing
actionlint(1.7.12) on all workflows: clean.shellcheckon the changed test script: clean.bash .github/scripts/ci-changes.test.sh: all checks pass. Withci.ymlput back to its old concurrency block, the two new checks fail, so they detect the change.Notes for reviewers
ci.yml. It has no draft gating: it runs the same jobs for a draft and a ready pull request, and its required check isBuild and type-check. Onlycodeql.yml, which is not required, has it.publish.ymlis unchanged. It already usescancel-in-progress: false.ci.ymloropenapi-validate.ymlno longer cancels an earlier manual run on the same ref.Checklist