Repository navigation
docs(guides): rewrite the type, sync, archive and deploy guides - #557
Merged
Merged
Conversation
aicayzer
marked this pull request as ready for review
October 21, 2026 16:17
aicayzer
commented
Oct 21, 2026
aicayzer
left a comment
Contributor
Author
There was a problem hiding this comment.
Review: ready to merge
Summary. Rewrites Define a type, Keep a copy in sync, Export and restore and Deploy shorter and in the reader's order; true against marfa v0.0.21 after four fixes.
First draft: 4/5. No blocking finding; quick fixes that mattered, in 560e38e.
Checked.
- True: export formats,
state=any,files=false, the archive's files,missing_blobs,.incompleteand the refusals; restore rules and on-screen labels; the Dockerfile settings, the two secrets, the socket path,/health,instance/stop-within-eight, the sign-in limit; the shared-bucket claim (instance/replica-restores-own,instance/replica-under-prefix); type register, repeat, normalize, replace, delete andprovenance; the event frames and@withmarfa/client0.0.21 exports. - Every path: every link into and out of the four pages resolves.
Found.
- Running without a container implied the server reads
marfa.env. It doesn't, so a reader would have started with trial secrets. The page now says the settings must be in the server's environment. Fixed in 560e38e.Untrue against marfa - The CLI replaces the export path only when the export ended whole and lacks no files. Fixed in 560e38e.
Untrue against marfa resolved_type"never matches" and "within about eight seconds" overstated or blurred their rules. Fixed in 560e38e.Untrue against marfa
Quick fixes. 8 applied by the reviewer.
Reviewed by withmarfa-reviewer on claude-opus-5-5. This review may contain mistakes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rewrites four dense guides so each page does one job, in an order a reader can follow, with command output captured from a running instance. Every page is shorter than on
main, and no URL changes.Changes
receipt.jsononce. Each call then sends that file, so the body is no longer repeated nine times. Field keys and identifier rules link to the Catalog's Type rules instead of being repeated in a table. The strict-mode paragraph is now two sentences that link to Settings. The register response now includesprovenance, as v0.0.21 returns it.sync.tsin five<Steps>, with each step adding its own piece of code. Definesapply,saveCursor,rebuildandfollowwhere they first appear. Replaces the 600-character SSE line with realmarfa eventsoutput in a<Terminal>and a short raw-frame example. Replaces the stub section with one sentence that links to the read-views chapter.###sections are now##sections. On-screen names are bold. The three command and output pairs are in<Terminal>. Inline contract IDs move to the footer.marfa.env, start the container, then claim the instance. The configuration reference follows. Bold drops from 20 phrases to 8. The six inline contract IDs move to the footer. The Docker subnet aside is now part of theTRUSTED_PROXY_CIDRSbullet. The socket's401rule now names what needs a key, as v0.0.21's CLI says it.NODE_ENVto#run-it-without-a-container, because#what-the-server-needsis gone. The changelog's normalize entry now links to#change-the-type. Deploy keeps#the-private-socketas a subheading, because Manage keys and Sign in as the owner link to it.Testing
pnpm testpassed (364 tests, including the content lint).pnpm build,pnpm build:statusandpnpm types:checksucceeded.pnpm dev: at desktop width in headless Chromium, and at 375 px in a browser, with no horizontal page scroll. Each.mdcopy was read. Steps, Terminal and Files render as headings and plain fenced blocks.v0.0.21tag, on a fresh database:POST /types(201, withprovenance), a repeat (409 type_already_exists), normalize, replace and delete.marfa events --type core.note --edges none --from 4, and the raw SSE frames from cursor 5.sync.tswith@withmarfa/client@0.0.21passedtscwith no errors. It rebuilt the copy, applied a live create and a purge, and rebuilt after a forcedcursor_ahead. (Thecursor_aheadrun was on v0.0.20.)marfa exportfollowed bytar -tzf. An export with one blob file removed exited 1, kept<path>.incomplete, and listed the blob undermissing_blobs.marfa --socket ... restoreinto a second fresh instance, run twice (duplicates,already_present). A key's restore was refused403 forbidden.401message,/healthcomponents, and the image'sENVandHEALTHCHECKlines.blobs_missing.Notes for reviewers
mainmoved to v0.0.21 during the work, so I re-ran the captures and reread the v0.0.21 contract diff for types, events, export and restore, instance and device. Two changes affected these pages: the typeprovenanceand the socket's401wording. Both are updated.deploy/README.md, not a contract rule...., and the page says so.Checklist
src/generated/oropenapi.json, and no internal hostnames, personal paths, keys or tokens.